This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Replace locally defined XFile type with cross_file package #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
force-pushed
the
file_selector_cross_file
branch
from
a465c77
to
e6c1a3b
Compare
ditman
reviewed
Nov 24, 2020
| @@ -1,3 +1,2 @@ | |||
| export 'x_file/x_file.dart'; | |||
|
|
|||
| export 'package:cross_file/cross_file.dart'; | |||
There was a problem hiding this comment.
Should we reexport cross_file from here, or should we ask app users to depend on cross_file themselves? How would this behave if we have multiple plugins that use cross_file? WDYT @stuartmorgan?
There was a problem hiding this comment.
Forcing users to manually depend on another package that is required for using this one seems problematic. I don't know what happens if two different packages export the same third package though. Presumably it just means it's accessible via both namespaces?
There was a problem hiding this comment.
Presumably it just means it's accessible via both namespaces?
Yeah, I think you're right, we can leave this here as a convenience.
ditman
approved these changes
Nov 24, 2020
phamnhuvu-dev
added a commit
to manabie-com/plugins
that referenced
this pull request
Jan 12, 2021
phamnhuvu-dev
added a commit
to manabie-com/plugins
that referenced
this pull request
Jan 12, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Feb 8, 2021
adsonpleal
pushed a commit
to nubank/plugins
that referenced
this pull request
Feb 26, 2021
samandmoore
added a commit
to Betterment/plugins
that referenced
this pull request
Apr 21, 2021
…m-changes * upstream-share-final-null-release: (233 commits) [q-w] Update Flutter SDK constraint (flutter#3323) [i-p] Update Flutter SDK constraint (flutter#3322) [d-g] Update Flutter SDK constraint (flutter#3321) [a-c] Update Flutter SDK constraint (flutter#3320) [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309) Exclude null-safe plugins from testing on stable (flutter#3318) [documentation] [url_launcher] fix for readme code sample (flutter#3308) [camera] Add zoom support to platform interface (flutter#3312) update analysis options for nnbd (flutter#3319) [camera] Suppress unchecked cast warning in java test (flutter#3316) [image_picker] [integration_test] Fixes to make the tree green (flutter#3317) [camera] Expanded platform interface to support setting flash mode (flutter#3313) [Espresso] Android Code Inspection and Clean up (flutter#3111) [camera] Add `camera_platform_interface` package (flutter#3253) [camera] Support Android 30 (flutter#3299) bump integration test to 1.0.0 (flutter#3295) [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288) Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279) [file_selector_platform_interface] Migrate to cross_file package (flutter#3286) Fix broken link (flutter#3280) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the locally defined
XFiletypes with those defined in the cross_file package.Related Issues
Fixes flutter/flutter#70950
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?