This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Replace locally defined XFile type with cross_file package #3286
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
packages/file_selector/file_selector_platform_interface/CHANGELOG.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
packages/file_selector/file_selector_platform_interface/lib/src/types/types.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
export 'x_file/x_file.dart'; | ||
|
||
export 'package:cross_file/cross_file.dart'; | ||
export 'x_type_group/x_type_group.dart'; |
82 changes: 0 additions & 82 deletions
82
packages/file_selector/file_selector_platform_interface/lib/src/types/x_file/base.dart
This file was deleted.
Oops, something went wrong.
132 changes: 0 additions & 132 deletions
132
packages/file_selector/file_selector_platform_interface/lib/src/types/x_file/html.dart
This file was deleted.
Oops, something went wrong.
54 changes: 0 additions & 54 deletions
54
packages/file_selector/file_selector_platform_interface/lib/src/types/x_file/interface.dart
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we reexport cross_file from here, or should we ask app users to depend on cross_file themselves? How would this behave if we have multiple plugins that use cross_file? WDYT @stuartmorgan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forcing users to manually depend on another package that is required for using this one seems problematic. I don't know what happens if two different packages export the same third package though. Presumably it just means it's accessible via both namespaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think you're right, we can leave this here as a convenience.