Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Split to multiple PRs in progress] Remove use of yourcompany.com #386

Closed
wants to merge 7 commits into from

Conversation

mravn-google
Copy link
Contributor

@mravn-google mravn-google commented Feb 14, 2018

Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Feb 15, 2018

Are there directories that need renaming as a result?

@mravn-google
Copy link
Contributor Author

@Hixie The package/directory renaming happened earlier as part of the latest Android template refresh.

@Hixie
Copy link
Contributor

Hixie commented Mar 9, 2018

Is this ready to land?

@mravn-google
Copy link
Contributor Author

Not quite yet. I still need to remove references to yourcompany.com from the Firebase projects (which means recreating those projects, as I have no access to those originally used).

@Hixie
Copy link
Contributor

Hixie commented Mar 20, 2018

Any news? (Just going through open PRs; this is one of the oldest.)

@mravn-google mravn-google changed the title Remove use of yourcompany.com [Split to multiple PRs in progress] Remove use of yourcompany.com Mar 29, 2018
@mravn-google
Copy link
Contributor Author

PR split up into #447, #448, #449, #450, #451.

@mravn-google mravn-google deleted the remove_yourcompany branch June 4, 2018 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants