This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Remove yourcompany.com from cloud_firestore #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@collinjackson If this PR is at odds with your pending work, feel free to just close it. But please consider removing use of |
collinjackson
approved these changes
Apr 1, 2018
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of several (extracted from #386) intended to remove all remaining uses of
yourcompany.comfrom the plugin repo.Since
yourcompany.comwas previously part of app IDs, the Google services json/plist files and their their source Firebase projects need updating. I do not have access to the original Firebase project used, and so created a new one. (@collinjackson feel free to push back on this, e.g. by sending me updated Google services files generated from the original project.)For
cloud_firestorein particular, a few other corrections were made in #386, and replicated here: