Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Exclude some missing integration tests #3872

Merged
merged 2 commits into from
May 10, 2021
Merged

Exclude some missing integration tests #3872

merged 2 commits into from
May 10, 2021

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented May 10, 2021 •
edited

ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan
Exclude ios_platform_images from integration tests
ce8dd1c 
It does not currently have an integration test, so must be explicitly
excluded due to recent tooling changes.

See flutter/flutter#82208
@google-cla google-cla bot added the cla: yes label May 10, 2021
cyanglaz
cyanglaz approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan changed the title Exclude ios_platform_images from integration tests Exclude some missing integration tests May 10, 2021
@stuartmorgan
Copy link
Contributor Author

Landing on red to fix breakage.

@stuartmorgan stuartmorgan merged commit 0474ef8 into flutter:master May 10, 2021
@stuartmorgan stuartmorgan deleted the ios-platform-images-e2e-exclude branch May 10, 2021 20:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
028286d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
3a4140e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
1b7fd50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
f5e5f9c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
46eba50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
af4cc34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
2e6a4f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
22764d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
4a1eb30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
b3e391e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
ff5a39f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
000df79
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
d4e2b62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
24b1d87
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
7abe50b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
0474ef8 Exclude some missing integration tests (flutter/plugins#3872)
b842ca5
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Exclude some missing integration tests (flutter#3872)
07f8069 
ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @cyanglaz