Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[file_selector] app-facing package missing web integration tests #82211

Closed
stuartmorgan opened this issue May 10, 2021 · 4 comments
Closed

[file_selector] app-facing package missing web integration tests #82211

stuartmorgan opened this issue May 10, 2021 · 4 comments
Labels
p: file_selector The file_selector plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically

Comments

@stuartmorgan
Copy link
Contributor

We have integration tests for file_selector_web, but we're not running any web integration tests for the app-facing package. Presumably this would just be a case of copying the current tests and adapting them to use the app-facing package instead.
@stuartmorgan stuartmorgan added plugin platform-web Web applications specifically P2 Important issues not at the top of the work list p: file_selector The file_selector plugin labels May 10, 2021
@stuartmorgan stuartmorgan mentioned this issue May 10, 2021
Merged
11 tasks
stuartmorgan added a commit to flutter/plugins that referenced this issue May 10, 2021
@stuartmorgan
Exclude some missing integration tests (#3872)
0474ef8 
ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211
@ditman
Copy link
Member

ditman commented Jul 22, 2021

file_selector has the same problem as image_picker, it needs to drive a native UI element to select files.

fotiDim pushed a commit to fotiDim/plugins that referenced this issue Sep 13, 2021
@stuartmorgan @fotiDim
Exclude some missing integration tests (flutter#3872)
07f8069 
ios_platform_images does not currently have an integration test, and file_chooser does not have a web integration test, so both must be explicitly excluded due to recent tooling changes.

See:
flutter/flutter#82208
flutter/flutter#82211
@gantelo
Copy link

gantelo commented Sep 13, 2022

Hi @stuartmorgan, I was looking into starting contributing a bit to the project.
I don't follow this issue, though. Should I just copy the integration tests from file_selector_web to the file_selector folder and adapt them to run there 'natively'?

@stuartmorgan
Copy link
Contributor Author

This should actually be closed, since we don't have a mechanism for running web integration tests with native UI. I misunderstood the existing tests when I filed this.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: file_selector The file_selector plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stuartmorgan @ditman @gantelo @mamuseferha