Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] android-rework part 6: Android exposure- and focus point features #4039

Merged
merged 6 commits into from
Jun 23, 2021
Merged

[camera] android-rework part 6: Android exposure- and focus point features #4039

merged 6 commits into from
Jun 23, 2021

Conversation

BeMacized
Copy link
Contributor

Adds exposure- and focus point features containing the implementation to handle setting the exposure- and focus point via the Android Camera2 API.

This is the sixth PR in a series of pull-requests which will gradually introduce changes from PR #3651, making it easier to review the code (as discussed with @stuartmorgan).

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See [plugin_tool format])
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
    • Since this will be a series of pull-requests I will update the version in the last PR of the series.
  • I updated CHANGELOG.md to add a description of the change.
    • Since this will be a series of pull-requests I will update the version in the last PR of the series.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@google-cla google-cla bot added the cla: yes label Jun 10, 2021
@stuartmorgan stuartmorgan self-requested a review June 10, 2021 20:02
mvanbeusekom
mvanbeusekom approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stuartmorgan
stuartmorgan approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits from skimming (I didn't look closely at everything since it's already been reviewed).

packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/CameraRegionUtils.java Outdated Show resolved Hide resolved
...oid/src/main/java/io/flutter/plugins/camera/features/exposurepoint/ExposurePointFeature.java Outdated Show resolved Hide resolved
@mvanbeusekom
Copy link
Contributor

@BeMacized can you have another look at this? According to the tree there are some JAVA tests failing after your latest changes.

@BeMacized
Copy link
Contributor Author

@mvanbeusekom Yes, my bad! They should be fixed now.

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 23, 2021
@fluttergithubbot fluttergithubbot merged commit 77f4a36 into flutter:master Jun 23, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2021
@engine-flutter-autoroll
77f4a36 [camera] android-rework part 6: Android exposure- and focus p…
0b2f0cb 
…oint features (flutter/plugins#4039)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2021
@engine-flutter-autoroll
77f4a36 [camera] android-rework part 6: Android exposure- and focus p…
56cf591 
…oint features (flutter/plugins#4039)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@BeMacized @amantoux
[camera] android-rework part 6: Android exposure- and focus point fea…
dd69854 
…tures (flutter#4039)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@BeMacized @fotiDim
[camera] android-rework part 6: Android exposure- and focus point fea…
6a03135 
…tures (flutter#4039)
@mvanbeusekom mvanbeusekom deleted the camera-android/exposure_focus_point_features branch September 21, 2021 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BeMacized @mvanbeusekom @stuartmorgan @fluttergithubbot