Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix CamcorderProfile Usages #4423

Merged
merged 50 commits into from Oct 29, 2021
Merged

[camera] Fix CamcorderProfile Usages #4423

merged 50 commits into from Oct 29, 2021

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Oct 11, 2021 •
edited

Removes usages of CamcorderProfile and related methods due to its deprecation.

Fixes #89578.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Oct 11, 2021
@camsim99 camsim99 changed the title [WIP] Fix CamcorderProfile Usages [WIP][camera] Fix CamcorderProfile Usages Oct 11, 2021
This was referenced Oct 13, 2021
Closed
Merged
blasten
blasten approved these changes Oct 18, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 18, 2021
@blasten
Copy link

blasten commented Oct 28, 2021

PTAL @stuartmorgan

stuartmorgan
stuartmorgan approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

...a/android/src/main/java/io/flutter/plugins/camera/features/resolution/ResolutionFeature.java Outdated
}
}

@SuppressWarnings("deprecation")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was marked as resolved, but is still present; is that a mistake, or is there a reason we need this? If the latter, please explain in a reply so that we have a record of it for people trying to understand this code later.

...droid/src/test/java/io/flutter/plugins/camera/features/resolution/ResolutionFeatureTest.java Outdated Show resolved Hide resolved
...droid/src/test/java/io/flutter/plugins/camera/features/resolution/ResolutionFeatureTest.java Outdated Show resolved Hide resolved
@camsim99 camsim99 added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2021
@fluttergithubbot fluttergithubbot merged commit 29f46b4 into flutter:master Oct 29, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2021
@engine-flutter-autoroll
29f46b4 [camera] Fix CamcorderProfile Usages (flutter/plugins#4423)
0ff8959
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 3, 2021
@engine-flutter-autoroll
29f46b4 [camera] Fix CamcorderProfile Usages (flutter/plugins#4423)
2f609bf
NickalasB added a commit to NickalasB/plugins that referenced this pull request Nov 4, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
e17df4c 
* master:
  [webview_flutter] Deprecate evaluateJavascript in favour of runJavaScript and runJavaScriptForResult. (flutter#4403)
  [webview_flutter] Add interface methods to load local files and HTML strings. (flutter#4446)
  [ci] add pedantic dep to new in_app_purchase pkgs (flutter#4471)
  [ci] Remove unused dep from file_selector. (flutter#4468)
  [ci] update build_runner dep in android_intent and file_selector example (flutter#4467)
  [webview_flutter] Add platform interface method `loadRequest`. (flutter#4450)
  Remove -Werror from deprecated plugin Android builds (flutter#4466)
  [webview_flutter] Update webview packages for Android and iOS to implement `runJavascript` and `runJavascriptReturningResult`. (flutter#4402)
  [camera] Fix CamcorderProfile Usages (flutter#4423)
  [google_sign_in] Use a transparent image as a placeholder for the `GoogleUserCircleAvatar` (flutter#4391)
  [in_app_purchase]IAP/platform interface add cancel status (flutter#4093)
  [image_picker] doc:readme image picker misprints (flutter#4421)
  Support Hybrid Composition through the GoogleMaps Widget (flutter#4082)
  [path_provider] started supporting background platform channels (flutter#4443)
  [device_info] started using Background Platform Channels (flutter#4456)

# Conflicts:
#	packages/webview_flutter/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/webview_flutter/pubspec.yaml
stuartmorgan added a commit to stuartmorgan/plugins that referenced this pull request Nov 15, 2021
@stuartmorgan
[camera] Fix version and CHANGELOG
de5869c 
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
@stuartmorgan stuartmorgan mentioned this pull request Nov 15, 2021
Merged
11 tasks
fluttergithubbot pushed a commit that referenced this pull request Nov 15, 2021
@stuartmorgan
[camera] Fix version and CHANGELOG (#4513)
b6e8d05 
#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
henri-henri pushed a commit to sofcograhapt/plugins that referenced this pull request Nov 29, 2021
@camsim99 @henri-henri
[camera] Fix CamcorderProfile Usages (flutter#4423)
253cf48 
(cherry picked from commit 29f46b4)
henri-henri pushed a commit to sofcograhapt/plugins that referenced this pull request Nov 29, 2021
@stuartmorgan @henri-henri
[camera] Fix version and CHANGELOG (flutter#4513)
a0744e7 
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659

(cherry picked from commit b6e8d05)
henri-henri added a commit to sofcograhapt/plugins that referenced this pull request Nov 29, 2021
@henri-henri
Revert "[camera] Fix CamcorderProfile Usages (flutter#4423) (cherry p…
bf2e3e4 
…icked from commit 29f46b4)"

This reverts commit 253cf48
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@camsim99 @amantoux
[camera] Fix CamcorderProfile Usages (flutter#4423)
794cf10
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan @amantoux
[camera] Fix version and CHANGELOG (flutter#4513)
ee746ea 
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@camsim99 @KyleFin
[camera] Fix CamcorderProfile Usages (flutter#4423)
26b2fb1
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan @KyleFin
[camera] Fix version and CHANGELOG (flutter#4513)
2d65892 
flutter#4423 incorrectly added changelog
entries to an already-published version instead of bumping the version,
whcih was missed during review.

Fixes flutter/flutter#93659
@ghost ghost mentioned this pull request Mar 7, 2022
Merged
@acoutts acoutts mentioned this pull request Aug 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes p: camera platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@camsim99 @blasten @stuartmorgan @fluttergithubbot