This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] doc:readme image picker misprints #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
reviewed
Oct 18, 2021
There was a problem hiding this comment.
LGTM, please update CHANGLOG to add a "NEXT" entry so the next release will include this message in CHANGELOG:
NEXT
* Fix typos in README.md.
Please ignore this comment and follow what @stuartmorgan said in #4421 (review)
stuartmorgan
suggested changes
Oct 20, 2021
There was a problem hiding this comment.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
This needs a version update, as described in the first FAQ in the link here.
In the future, please be sure to follow the PR checklist; it's there specifically to highlight things that PRs are likely to need in order to be successful.
…cker # Conflicts: # packages/image_picker/image_picker/CHANGELOG.md
vlkonoshenko
changed the title
|
@stuartmorgan Sorry for making such obvious mistakes. This is my first contribution experience in Flutter repo. I upgraded the version number and updated the CHANGELOG. |
stuartmorgan
suggested changes
Oct 21, 2021
| @@ -1,3 +1,7 @@ | |||
| ## NEXT | |||
There was a problem hiding this comment.
This needs the version.
stuartmorgan
approved these changes
Oct 21, 2021
cyanglaz
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Nov 4, 2021
* master: [webview_flutter] Deprecate evaluateJavascript in favour of runJavaScript and runJavaScriptForResult. (flutter#4403) [webview_flutter] Add interface methods to load local files and HTML strings. (flutter#4446) [ci] add pedantic dep to new in_app_purchase pkgs (flutter#4471) [ci] Remove unused dep from file_selector. (flutter#4468) [ci] update build_runner dep in android_intent and file_selector example (flutter#4467) [webview_flutter] Add platform interface method `loadRequest`. (flutter#4450) Remove -Werror from deprecated plugin Android builds (flutter#4466) [webview_flutter] Update webview packages for Android and iOS to implement `runJavascript` and `runJavascriptReturningResult`. (flutter#4402) [camera] Fix CamcorderProfile Usages (flutter#4423) [google_sign_in] Use a transparent image as a placeholder for the `GoogleUserCircleAvatar` (flutter#4391) [in_app_purchase]IAP/platform interface add cancel status (flutter#4093) [image_picker] doc:readme image picker misprints (flutter#4421) Support Hybrid Composition through the GoogleMaps Widget (flutter#4082) [path_provider] started supporting background platform channels (flutter#4443) [device_info] started using Background Platform Channels (flutter#4456) # Conflicts: # packages/webview_flutter/webview_flutter/CHANGELOG.md # packages/webview_flutter/webview_flutter/pubspec.yaml
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme image picker misprints
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.