Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Adjust pull request template #4478

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Nov 5, 2021

  • Switch the test exemption to link to the policy, matching flutter/flutter.
  • Update the wording of the version change step to make it clear that there is a specific exception list to check against, making it both clearer, and consistent with the test item.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

- Switch the test exemption to link to the policy, matching flutter/flutter, but with a (temporary) note about the fact that the bot isn't running yet
- Update the wording of the version change step to make it clear that there is a specific exception list to check against, making it both clearer, and consistent with the test item.
@stuartmorgan
Copy link
Contributor Author

Added backticks per the other PR.

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 9, 2021
@fluttergithubbot fluttergithubbot merged commit 1a2fbe8 into master Nov 10, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 10, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan stuartmorgan deleted the minor-pr-template-update branch April 19, 2022 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants