Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Disable camera/quick_actions tests temporarily #4487

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

blasten
Copy link

@blasten blasten commented Nov 8, 2021

Temporarily disables the tests until the methods added in flutter/engine#29574 have default implementations.

Related issue: flutter/flutter#93286

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@blasten blasten changed the title Implement BinaryMessenger new methods Disable camera/quick_actions tests temporarily Nov 8, 2021
@blasten
Copy link
Author

blasten commented Nov 9, 2021

Merging to fix the tree. The iOS failure is unrelated.

@blasten blasten merged commit 638dd07 into flutter:master Nov 9, 2021
@blasten blasten deleted the fix_tests branch November 9, 2021 02:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2021
blasten pushed a commit that referenced this pull request Nov 12, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants