This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Eliminate platform channel from mock platform #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When video_player was federated, the existing unit tests in the app-facing package--which were based on mocking out the method channel--were left as-is. Because of the use of Pigeon, and thus Pigeon-generated mocks, this creates a dependency from the test code in the app-facing package on test code that is published from the platform interface package, which causes unwanted dependencies in the platform interface. This updates the tests in the app-facing package to follow best practices for federated plugins, which is for the app-facing tests to directly mock/fake the platform interface, not depend on the method-channel-based implementation. This simplifies the tests, ensures that they aren't also testing code from another package, and allows for removing the test code from the public interface of the platform interface package (in a seperate follow-up PR). In order to allow the tests to work, the controller's caching of the platform instance is changed to allow it to notice changes. Part of flutter/flutter#83562
This comment has been minimized.
This comment has been minimized.
stuartmorgan
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When video_player was federated, the existing unit tests in the
app-facing package--which were based on mocking out the method
channel--were left as-is. Because of the use of Pigeon, and thus
Pigeon-generated mocks, this creates a dependency from the test code in
the app-facing package on test code that is published from the platform
interface package, which causes unwanted dependencies in the platform
interface.
This updates the tests in the app-facing package to follow best
practices for federated plugins, which is for the app-facing tests to
directly mock/fake the platform interface, not depend on the
method-channel-based implementation. This simplifies the tests, ensures
that they aren't also testing code from another package, and allows for
removing the test code from the public interface of the platform
interface package (in a seperate follow-up PR).
In order to allow the tests to work, the controller's caching of the
platform instance is changed to allow it to notice changes.
Part of flutter/flutter#83562
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).