Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Eliminate platform channel from mock platform #4588

Merged

Commits on Dec 7, 2021

  1. [video_player] Eliminate platform channel from mock platform

    When video_player was federated, the existing unit tests in the
    app-facing package--which were based on mocking out the method
    channel--were left as-is. Because of the use of Pigeon, and thus
    Pigeon-generated mocks, this creates a dependency from the test code in
    the app-facing package on test code that is published from the platform
    interface package, which causes unwanted dependencies in the platform
    interface.
    
    This updates the tests in the app-facing package to follow best
    practices for federated plugins, which is for the app-facing tests to
    directly mock/fake the platform interface, not depend on the
    method-channel-based implementation. This simplifies the tests, ensures
    that they aren't also testing code from another package, and allows for
    removing the test code from the public interface of the platform
    interface package (in a seperate follow-up PR).
    
    In order to allow the tests to work, the controller's caching of the
    platform instance is changed to allow it to notice changes.
    
    Part of flutter/flutter#83562
    stuartmorgan committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    a5dcb2d View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Configuration menu
    Copy the full SHA
    dd5c611 View commit details
    Browse the repository at this point in the history