ignore upcoming warnings #5852
ignore upcoming warnings #5852
Conversation
github-actions
bot
added
p: webview_flutter
There was a problem hiding this comment.
Can you also add a TODO above these that says to remove the imports once flutter/flutter#104231 lands?
a14n
force-pushed
the
ignore-upcoming-warnings
branch
from
94954f7
to
37af759
Compare
Done. I also added a No version/CHANGELOG change to make publishable task happy. Please let me know if it's the good solution. |
There was a problem hiding this comment.
I also added a No version/CHANGELOG change to make publishable task happy. Please let me know if it's the good solution.
No, these need a version change because they don't meet our exemption criteria. These are warnings that will show up for clients of the plugin.
| @@ -2,6 +2,8 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
|
|
|||
| // TODO(a14n): remove this import once flutter/flutter#104231 lands | |||
There was a problem hiding this comment.
These TODOs aren't actually accurate; we need to remove the import when that PR reaches stable, because all of our plugins support the stable channel. It should say something like "once Flutter 3.1 or later reaches stable".
There was a problem hiding this comment.
Done. But given that this PR hasn't even reached master we should perhaps prefer once flutter/flutter#104231 reaches stable.
Done. Thanks for your help.
I'm not sure to understand what you refer to. Could you give me an example please? |
a14n
force-pushed
the
ignore-upcoming-warnings
branch
from
6e4e7ab
to
16892df
Compare
a14n
force-pushed
the
ignore-upcoming-warnings
branch
from
16892df
to
ba3321d
Compare
You will see these warnings; the same would happen for everyone else once that PR has landed. |
|
The client will see (new) warnings in its own code but he will not see warnings inside the Thanks for your feedback! |
Why wouldn't they see warnings from |
I just made a quick test and it looks like the analyzer don't show any warning from the dependency. |
No, in your app or package you will not see warnings that occur inside your dependencies. |
|
Oh, sorry about that. I must have just conflated the Dart behavior with the native plugin builds that I'm more used to. In that case you were correct that these don't need version changes (although should still have changelog changes). |
This PR will prevent warnings once flutter/flutter#104231 has landed.