-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] Implementation of the app facing WebViewController for v4 #6280
[webview_flutter] Implementation of the app facing WebViewController for v4 #6280
Conversation
packages/webview_flutter/webview_flutter/lib/src/v4/src/webview_controller.dart
Show resolved
Hide resolved
/// The following caches are cleared: | ||
/// 1. Browser HTTP Cache. | ||
/// 2. [Cache API](https://developers.google.com/web/fundamentals/instant-and-offline/web-storage/cache-api) caches. | ||
/// These are not yet supported in iOS WkWebView. Service workers tend to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referencing WkWebView
is probably too much of an internal implementation detail for a client-facing API.
return platform.getTitle(); | ||
} | ||
|
||
/// Set the scrolled position of this view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a consistent verb form, so this should be "Sets". Most of the methods after this point need the same change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I meant to change this to an approval when I left that last comment, since that was my only real concern. LGTM.
auto label is removed for flutter/plugins, pr: 6280, Failed to merge pr#: 6280 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Base branch was modified. Review and try the merge again., locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)]). |
Part of flutter/flutter#94051
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.