This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Default Android to Hybrid Composition #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
bparrishMines
approved these changes
Sep 1, 2022
Comment on lines
+17
to
+19
| // #enddocregion DisplayMode | ||
| runApp(const MaterialApp()); | ||
| // #docregion DisplayMode |
There was a problem hiding this comment.
I'm assuming this just cuts out the runApp line from the doc region? I didn't know you could do that. Took me a minute to understand it.
There was a problem hiding this comment.
Yep, code-excerpts lets you make non-contiguous pulls, and adds (by default) a // ... (or whatever makes sense for the language) in the generated output.
stuartmorgan
added
the
autosubmit
stuartmorgan
added a commit
to stuartmorgan/plugins
that referenced
this pull request
Sep 1, 2022
Some integration tests behave slightly differently on Android when using Hybrid Composition, and need to wait for a change to become true rather than it being immediately true. This replicates the changes from `google_maps_flutter_android` to the app-facing copy of those integration tests. Fixes tree breakage from publishing flutter#6334
11 tasks
stuartmorgan
added a commit
that referenced
this pull request
Sep 1, 2022
Some integration tests behave slightly differently on Android when using Hybrid Composition, and need to wait for a change to become true rather than it being immediately true. This replicates the changes from `google_maps_flutter_android` to the app-facing copy of those integration tests. Fixes tree breakage from publishing #6334
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
Some integration tests behave slightly differently on Android when using Hybrid Composition, and need to wait for a change to become true rather than it being immediately true. This replicates the changes from `google_maps_flutter_android` to the app-facing copy of those integration tests. Fixes tree breakage from publishing flutter#6334
curt-weber
pushed a commit
to KWRI/google_maps_flutter
that referenced
this pull request
Nov 3, 2022
Some integration tests behave slightly differently on Android when using Hybrid Composition, and need to wait for a change to become true rather than it being immediately true. This replicates the changes from `google_maps_flutter_android` to the app-facing copy of those integration tests. Fixes tree breakage from publishing flutter/plugins#6334
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Some integration tests behave slightly differently on Android when using Hybrid Composition, and need to wait for a change to become true rather than it being immediately true. This replicates the changes from `google_maps_flutter_android` to the app-facing copy of those integration tests. Fixes tree breakage from publishing flutter#6334
engine-flutter-autoroll
pushed a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2023
Some integration tests behave slightly differently on Android when using Hybrid Composition, and need to wait for a change to become true rather than it being immediately true. This replicates the changes from `google_maps_flutter_android` to the app-facing copy of those integration tests. Fixes tree breakage from publishing flutter/plugins#6334
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Android implementation to use Hybrid Composition by default.
It's debatable whether this is a breaking change (since code calling this API will still compile, and explicitly setting it will still do the same thing it used it, it just has a different default). I'm choosing to treat it as non-breaking given than the primary expected effect is working around a serious regression caused by the display mode change in Flutter 3.0.
This will make the documentation in the app-facing package incorrect about the default behavior, but I'll do a separate PR at the same time (combining them would fail the federation safety check even though it's technically okay in this case) to update those docs. Technically someone could have the old app-facing package with the old docs, but the new implementation package with the new default, and see a mismatch between docs and default, but that's an small edge case, and won't actually break anything, so isn't worth making it a breaking change just for that.
Mostly resolves flutter/flutter#103686 until we can fix updates under TLHC.
Mostly resolves flutter/flutter#39797, although we should ensure that's fixed under TLHC (it may already be).
Fixes flutter/flutter#93335
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).