[google_maps_flutter] Deprecate AndroidGoogleMapsFlutter #6335
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: configuration change |
| class AndroidGoogleMapsFlutter { | ||
| @Deprecated( |
There was a problem hiding this comment.
nit: Is it necessary to deprecate a private constructor.
There was a problem hiding this comment.
Yes, otherwise we get https://dart-lang.github.io/linter/lints/deprecated_consistency.html. At first I thought it was a bug, but then I realized that we're using deprecated_member_use_from_same_package: ignore in Flutter repos, and without that it would make sense because other code in the library that referenced the private constructor should get a warning.
stuartmorgan
added
the
autosubmit
Deprecates the
AndroidGoogleMapsFlutterwrapper around platform view mode selection, in favor of pointing people to the implementation package. This is more consistent with how we do highly platform-specific things in federated plugins in general, and fixes the problem of having the default behavior documented here but specified in another package (see #6334).Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).