[webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview #6856

bparrishMines · 2022-12-16T16:12:15Z

Copies webview_flutter from v4_webview branch.
Updates pubspec.yaml, CHANGELOG.md. and README.
- Quick link to see README: https://github.com/bparrishMines/plugins/blob/webview_flutter_release/packages/webview_flutter/webview_flutter/README.md
- Added example/lib/simple_example.dart to add a simple example to readme with excerpt.
- Made some changes to example/lib/main.dart to improve excerpts.
- Copied fixes to integration tests from [webview_flutter_android] Fix timeouts in the integration tests #6857
Remove all webview packages from exclude plugins config file.

Fixes flutter/flutter#94051

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…r_release

stuartmorgan · 2022-12-16T19:53:25Z

packages/webview_flutter/webview_flutter/CHANGELOG.md

 * Updates code for `no_leading_underscores_for_local_identifiers` lint.
-* Updates minimum Flutter version to 2.10.
+* Updates minimum Flutter version to 3.0.0.
 * Fixes avoid_redundant_argument_values lint warnings and minor typos.
 * Ignores unnecessary import warnings in preparation for [upcoming Flutter changes](https://github.com/flutter/flutter/pull/104231).


Let's collapse these two and the underscores one above to a catch-all "Updates code for new analysis options." so there's less minor stuff listed in with the big change.

packages/webview_flutter/webview_flutter/CHANGELOG.md

stuartmorgan · 2022-12-16T19:55:45Z

packages/webview_flutter/webview_flutter/README.md

@@ -1,41 +1,73 @@
 # WebView for Flutter

+<?code-excerpt path-base="excerpts/packages/webview_flutter_example"?>


Thanks! You can remove this package from script/configs/temp_exclude_excerpt.yaml in this PR as well.

stuartmorgan · 2022-12-16T19:57:15Z

packages/webview_flutter/webview_flutter/README.md

@@ -45,54 +77,141 @@ android {
 }
 ```

-### Using Virtual displays
+### Platform Specific Features


Nit: Platform-Specific Features

stuartmorgan · 2022-12-16T19:57:25Z

packages/webview_flutter/webview_flutter/README.md


-1. Set the correct `minSdkVersion` in `android/app/build.gradle` (if it was previously lower than 20):
+Many classes have a subclass or an underlying implementation that provides access to platform
+specific features.


Same here: platform-specific features

stuartmorgan · 2022-12-16T20:08:00Z

packages/webview_flutter/webview_flutter/README.md

+
+### Replacing WebView Functionality
+
+The `WebView` class has been removed and it's functionality has been split into `WebViewController`


stuartmorgan · 2022-12-16T20:08:10Z

packages/webview_flutter/webview_flutter/README.md

+and `WebViewWidget`.
+
+`WebViewController` handles all functionality that is associated with the underlying WebView
+provided by each platform. (e.g. loading a url, setting the background color of the underlying


Nit: "e.g.,"

stuartmorgan · 2022-12-16T20:08:51Z

packages/webview_flutter/webview_flutter/README.md

+The `WebView` class has been removed and it's functionality has been split into `WebViewController`
+and `WebViewWidget`.
+
+`WebViewController` handles all functionality that is associated with the underlying WebView


Nit: "underlying web view" since it's referring to the concept rather than a class.

packages/webview_flutter/webview_flutter/README.md

stuartmorgan · 2022-12-16T20:14:01Z

packages/webview_flutter/webview_flutter/README.md

+  * `WebView.initialMediaPlaybackPolicy` -> `WebKitWebViewControllerCreationParams.mediaTypesRequiringUserAction`
+  * `WebView.allowsInlineMediaPlayback` -> `WebKitWebViewControllerCreationParams.allowsInlineMediaPlayback`
+
+## Enable Material Components for Android


Shouldn't this and the next section still be ### headings under ## Usage?

…erpt tests

…r_release

stuartmorgan

LGTM with one last README nit, plus removing the platform-layer-only types from the this package's export list, per your comment. Since the export issue only applies to using the platform interface, we can remove them here and land this, and make the implementation re-export fixes in parallel, right (rather than having to wait to land those package updates before landing this)?

stuartmorgan · 2022-12-17T00:22:15Z

packages/webview_flutter/webview_flutter/README.md

+  * `WebView.gestureNavigationEnabled` -> `WebKitWebViewController.setAllowsBackForwardNavigationGestures`
+  * `WebView.initialMediaPlaybackPolicy` -> `WebKitWebViewControllerCreationParams.mediaTypesRequiringUserAction`
+  * `WebView.allowsInlineMediaPlayback` -> `WebKitWebViewControllerCreationParams.allowsInlineMediaPlayback`
+
 ### Enable Material Components for Android


Sorry, my last comment wasn't very clear. These should be ### as you've done, but they also need to be moved up to just before the new ## Migrating from 3.0 to 4.0 section so that they are nested under Usage rather than the migration section.

bparrishMines · 2022-12-17T02:00:35Z

@stuartmorgan Thanks for your help for getting this though so late!

…ew_flutter from v4_webview (flutter/plugins#6856)

* 5f62d21eb [local_auth] Fix failed biometric authentication not throwing error (flutter/plugins#6821) * ca974ab0c [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (flutter/plugins#6854) * 4d11be416 [image_picker] Don't store null paths in lost cache (flutter/plugins#6678) * fd2841fd0 [webview_flutter_android] Fix timeouts in the integration tests (flutter/plugins#6857) * abc9f9a9b [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (flutter/plugins#6853) * 7efb5e89d [video_player] Add compatibility with the current platform interface (flutter/plugins#6855) * 32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more image types (flutter/plugins#6812) * 840a04954 [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (flutter/plugins#6856)

…#117314) * 5f62d21eb [local_auth] Fix failed biometric authentication not throwing error (flutter/plugins#6821) * ca974ab0c [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (flutter/plugins#6854) * 4d11be416 [image_picker] Don't store null paths in lost cache (flutter/plugins#6678) * fd2841fd0 [webview_flutter_android] Fix timeouts in the integration tests (flutter/plugins#6857) * abc9f9a9b [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (flutter/plugins#6853) * 7efb5e89d [video_player] Add compatibility with the current platform interface (flutter/plugins#6855) * 32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more image types (flutter/plugins#6812) * 840a04954 [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (flutter/plugins#6856)

… from v4_webview (flutter#6856) * copy code from v4_webview * version bump and readme update * work towards better readme * improvements * more readme progress * improvements * fix main and update more readme * excerpt changes and more 3.0 diffs * cookie manager update * remove packages from exclude list * lint * better range * isForMainFrame * load page after waiting for widget * fix integration tests * improve readme a bit * collapse changelong. update platform-specific wording. include in excerpt tests * use platform implementation packages * include missing exports * PR comments * correct spelling * interface dev dependency * move other usage above migration * remove interface classes

bparrishMines added 12 commits December 15, 2022 13:51

copy code from v4_webview

7f876d1

version bump and readme update

56fceb9

work towards better readme

2a4b7d3

Merge branch 'main' of github.com:flutter/plugins into webview_flutte…

e90e7df

…r_release

improvements

b2480f8

more readme progress

0d4e703

Merge branch 'main' of github.com:flutter/plugins into webview_flutte…

9968f38

…r_release

improvements

301fafa

fix main and update more readme

e56c091

excerpt changes and more 3.0 diffs

65d28ed

cookie manager update

c41fa5b

remove packages from exclude list

f5e7243

github-actions bot added the p: webview_flutter Edits files for a webview_flutter plugin label Dec 16, 2022

bparrishMines added 7 commits December 16, 2022 11:54

lint

720082e

better range

de00284

isForMainFrame

fc2d6cb

load page after waiting for widget

f1c7a65

fix integration tests

b206a23

Merge branch 'main' of github.com:flutter/plugins into webview_flutte…

998d8ae

…r_release

improve readme a bit

a496fef

bparrishMines changed the title ~~Webview flutter release~~ [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview Dec 16, 2022

bparrishMines requested a review from stuartmorgan December 16, 2022 19:44

stuartmorgan suggested changes Dec 16, 2022

View reviewed changes

bparrishMines added 6 commits December 16, 2022 16:01

collapse changelong. update platform-specific wording. include in exc…

feb0b2e

…erpt tests

use platform implementation packages

fcf987d

include missing exports

4ff354b

PR comments

72f1db8

correct spelling

45d1a34

Merge branch 'main' of github.com:flutter/plugins into webview_flutte…

cc30a02

…r_release

bparrishMines requested a review from stuartmorgan December 16, 2022 21:49

interface dev dependency

cc24cbb

stuartmorgan approved these changes Dec 17, 2022

View reviewed changes

bparrishMines added 2 commits December 16, 2022 19:53

move other usage above migration

52069b3

remove interface classes

dbc20fa

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2022

auto-submit bot merged commit 840a049 into flutter:main Dec 17, 2022

bparrishMines deleted the webview_flutter_release branch December 17, 2022 02:02

engine-flutter-autoroll mentioned this pull request Dec 19, 2022

Roll Plugins from cbcf50726fb9 to 840a04954fa0 (8 revisions) flutter/flutter#117314

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2022

840a04954 [webview_flutter] Copies app-facing implementation of webvi…

47930ff

…ew_flutter from v4_webview (flutter/plugins#6856)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview #6856

[webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview #6856

bparrishMines commented Dec 16, 2022 •

edited

Loading

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan Dec 16, 2022

stuartmorgan left a comment

stuartmorgan Dec 17, 2022

bparrishMines commented Dec 17, 2022

		@@ -1,41 +1,73 @@
		# WebView for Flutter

		<?code-excerpt path-base="excerpts/packages/webview_flutter_example"?>


		### Replacing WebView Functionality

		The `WebView` class has been removed and it's functionality has been split into `WebViewController`

[webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview #6856

[webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview #6856

Conversation

bparrishMines commented Dec 16, 2022 • edited Loading

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bparrishMines commented Dec 17, 2022

bparrishMines commented Dec 16, 2022 •

edited

Loading