[image_picker] Improve image_picker for iOS to handle more image types #6812

vashworth · 2022-12-08T16:58:52Z

Changes iOS image picker (iOS 14+) to use NSItemProvider's method loadDataRepresentationForTypeIdentifier:completionHandler: instead of loadObjectOfClass:completionHandler:.

The loadObjectOfClass method is unable to convert some image types directly into a UIImage. For example, WebP and ProRaw images return an error of Could not coerce an item to class UIImage. However, loadDataRepresentationForTypeIdentifier is able to load all image types that conform to UTTypeImage (UTTypeHEIC, UTTypeHEIF, UTTypeLivePhoto, UTTypeICO, UTTypeICNS, UTTypePNG, UTTypeGIF, UTTypeJPEG, UTTypeWebP, UTTypeTIFF, UTTypeBMP, UTTypeSVG, UTTypeRAWImage) into NSData, which can then be converted into a UIImage.

Fixes flutter/flutter#92100.
Fixes flutter/flutter#95885.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

mark8044 · 2022-12-11T02:30:15Z

This is much needed, thank you much @vashworth

…_not_loading

jmagman

Missed there was a previous similar PR about this #4665

.../image_picker/image_picker_ios/example/ios/RunnerTests/PickerSaveImageToPathOperationTests.m

packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m

jmagman

If you make the Fixes #issue on its own lines then GitHub will handle linking the PR to the issues and will auto-close.

Fixes flutter/flutter#92100, flutter/flutter#95885.

@cyanglaz anything to add, since you also reviewed #4665

jmagman · 2022-12-13T21:39:38Z

Needs formatting:

patch -p1 <<DONE
diff --git a/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m b/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
index 7cc50791a..16c205012 100644
--- a/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
+++ b/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
@@ -102,7 +102,8 @@ typedef void (^GetSavedPath)(NSString *);
                                     UIImage *image = [[UIImage alloc] initWithData:data];
                                     [self processImage:image];
                                   } else {
-                                    os_log_error(OS_LOG_DEFAULT, "Could not process image: %@", error);
+                                    os_log_error(OS_LOG_DEFAULT, "Could not process image: %@",
+                                                 error);
                                   }
                                 }];
     }

DONE

jmagman · 2022-12-13T22:21:45Z

.../image_picker/image_picker_ios/example/ios/RunnerTests/PickerSaveImageToPathOperationTests.m

@@ -55,6 +55,76 @@ - (void)testSaveGIFImage API_AVAILABLE(ios(14)) {
  [self verifySavingImageWithPickerResult:result fullMetadata:YES];
 }

+- (void)testSaveBMPImage API_AVAILABLE(ios(14)) {


Are you able to test the pre-iOS 14 codepath without using PHPickerResult?

Never mind, that code is dead, FLTPHPickerSaveImageToPathOperation is only available on iOS 14.

.../image_picker/image_picker_ios/example/ios/RunnerTests/PickerSaveImageToPathOperationTests.m

cyanglaz

LGTM!

LabN36 · 2022-12-16T00:59:14Z

I just tested vashworth:image_picker_images_not_loading branch and it doesn't seems to be working properly.

I have couple of RAW files in my real iPhone13 Pro device and it does not complete the future and throws error("Cancelled by a second request") next time when I'm about tho pick file.(which was the ultimate problem with this package)

I just simply ran image_picker/plugins/packages/image_picker/image_picker_ios/example/main.dart file
here is logs I get

[claims] grantAccessClaim reply is an error: Error Domain=NSCocoaErrorDomain Code=4097 "Couldn’t communicate with a helper application." UserInfo={NSUnderlyingError=0x283995c50 {Error Domain=NSCocoaErrorDomain Code=4097 "connection from pid 9395 on anonymousListener or serviceListener" UserInfo={NSDebugDescription=connection from pid 9395 on anonymousListener or serviceListener}}}
Could not process image: Error Domain=NSItemProviderErrorDomain Code=-1000 "Cannot load representation of type com.adobe.raw-image" UserInfo={NSLocalizedDescription=Cannot load representation of type com.adobe.raw-image, NSUnderlyingError=0x283995fe0 {Error Domain=NSCocoaErrorDomain Code=4097 "Couldn’t communicate with a helper application." UserInfo={NSUnderlyingError=0x283995c50 {Error Domain=NSCocoaErrorDomain Code=4097 "connection from pid 9395 on anonymousListener or serviceListener" UserInfo={NSDebugDescription=connection from pid 9395 on anonymousListener or serviceListener}}}}}

LabN36 · 2022-12-16T01:08:36Z

Also strangely it does work on some of RAW the file but for some RAW files it does.
FYI: I've ran on iOS 16.1.3 iPhone 13 Pro

Here are the sample files which doesn't seems to be working
https://drive.google.com/drive/folders/18S-5pMnJvQhAKpsuwabDCjoxhsk1RR_g?usp=share_link

File Specs
31.6Mb RAW Files
Wide Camera - 26 mm f1.5
ISO 100 | 26mm | 0 ev | f1.5 | 1/121 s

jmagman · 2022-12-16T03:01:10Z

I have couple of RAW files in my real iPhone13 Pro device and it does not complete the future and throws error("Cancelled by a second request") next time when I'm about tho pick file.(which was the ultimate problem with this package)

The canceled by a second request issue is tracked with flutter/flutter#82602, which I'm working on now. However the underlying problem is that it can't load the image:

Could not process image: Error Domain=NSItemProviderErrorDomain Code=-1000 "Cannot load representation of type com.adobe.raw-image" UserInfo={NSLocalizedDescription=Cannot load representation of type com.adobe.raw-image, NSUnderlyingError=0x283995fe0 {Error Domain=NSCocoaErrorDomain Code=4097 "Couldn’t communicate with a helper application."

There are other Apple dev threads complaining about the same: https://developer.apple.com/forums/thread/672379 and https://developer.apple.com/forums/thread/661834.

I wonder if trying again works, or if it perma-fails for a given image once it's decided it can't be accessed.

jmagman · 2022-12-16T22:06:41Z

Talked with @vashworth about this one, we decided to merge even with the inconsistent selection of the RAW files since this change is still better than what we had before--it's supporting a lot more image formats. Plus there are reports of this happening on Apple developer forums which makes me think the Cannot load representation of type is an iOS bug. Asked @vashworth to file a new issue for that to see if we can come up with a workaround.

vashworth · 2022-12-16T22:25:21Z

As @jmagman mentioned we decided to merge this. I was able to reproduce the issue @LabN36 had, and created a new issue for it with my findings: flutter/flutter#117240

…image types (flutter/plugins#6812)

* 5f62d21eb [local_auth] Fix failed biometric authentication not throwing error (flutter/plugins#6821) * ca974ab0c [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (flutter/plugins#6854) * 4d11be416 [image_picker] Don't store null paths in lost cache (flutter/plugins#6678) * fd2841fd0 [webview_flutter_android] Fix timeouts in the integration tests (flutter/plugins#6857) * abc9f9a9b [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (flutter/plugins#6853) * 7efb5e89d [video_player] Add compatibility with the current platform interface (flutter/plugins#6855) * 32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more image types (flutter/plugins#6812) * 840a04954 [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (flutter/plugins#6856)

…#117314) * 5f62d21eb [local_auth] Fix failed biometric authentication not throwing error (flutter/plugins#6821) * ca974ab0c [webview_flutter_web] Copies web implementation of webview_flutter from v4_webview (flutter/plugins#6854) * 4d11be416 [image_picker] Don't store null paths in lost cache (flutter/plugins#6678) * fd2841fd0 [webview_flutter_android] Fix timeouts in the integration tests (flutter/plugins#6857) * abc9f9a9b [flutter_plugin_tools] If `clang-format` does not run, fall back to other executables in PATH (flutter/plugins#6853) * 7efb5e89d [video_player] Add compatibility with the current platform interface (flutter/plugins#6855) * 32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more image types (flutter/plugins#6812) * 840a04954 [webview_flutter] Copies app-facing implementation of webview_flutter from v4_webview (flutter/plugins#6856)

flutter#6812) * Improve image picker for ios to handle more image types * Update release info * different svg, remove raw test * change pro raw image * change pro raw image * add error log * fix formatting * fix image identifiers in test * get image type identifier from itemProvider in test

vashworth added 3 commits December 8, 2022 09:46

Improve image picker for ios to handle more image types

2cb9a17

Update release info

ca426d1

different svg, remove raw test

10970db

vashworth requested a review from cyanglaz as a code owner December 8, 2022 16:58

github-actions bot added p: image_picker platform-ios labels Dec 8, 2022

vashworth added 2 commits December 8, 2022 11:16

change pro raw image

a48fa37

change pro raw image

2f4bba5

Merge remote-tracking branch 'upstream/main' into image_picker_images…

23f07f4

…_not_loading

jmagman reviewed Dec 13, 2022

View reviewed changes

add error log

ecc0a8b

jmagman approved these changes Dec 13, 2022

View reviewed changes

fix formatting

0313fb8

jmagman reviewed Dec 13, 2022

View reviewed changes

fix image identifiers in test

1e65814

jmagman reviewed Dec 14, 2022

View reviewed changes

.../image_picker/image_picker_ios/example/ios/RunnerTests/PickerSaveImageToPathOperationTests.m Outdated Show resolved Hide resolved

get image type identifier from itemProvider in test

3636c7d

cyanglaz approved these changes Dec 15, 2022

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2022

auto-submit bot merged commit 32dcbf3 into flutter:main Dec 16, 2022

engine-flutter-autoroll mentioned this pull request Dec 19, 2022

Roll Plugins from cbcf50726fb9 to 840a04954fa0 (8 revisions) flutter/flutter#117314

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2022

32dcbf3e3 [image_picker] Improve image_picker for iOS to handle more …

d38c7b0

…image types (flutter/plugins#6812)

jmagman mentioned this pull request Feb 3, 2023

[image_picker][ios]: Unsupported file format 'public.heic' message while taking picture flutter/flutter#103248

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker] Improve image_picker for iOS to handle more image types #6812

[image_picker] Improve image_picker for iOS to handle more image types #6812

vashworth commented Dec 8, 2022 •

edited

Loading

mark8044 commented Dec 11, 2022

jmagman left a comment

jmagman left a comment

jmagman commented Dec 13, 2022

jmagman Dec 13, 2022 •

edited

Loading

jmagman Dec 13, 2022

cyanglaz left a comment

LabN36 commented Dec 16, 2022 •

edited

Loading

LabN36 commented Dec 16, 2022 •

edited

Loading

jmagman commented Dec 16, 2022

jmagman commented Dec 16, 2022

vashworth commented Dec 16, 2022

[image_picker] Improve image_picker for iOS to handle more image types #6812

[image_picker] Improve image_picker for iOS to handle more image types #6812

Conversation

vashworth commented Dec 8, 2022 • edited Loading

Pre-launch Checklist

mark8044 commented Dec 11, 2022

jmagman left a comment

Choose a reason for hiding this comment

jmagman left a comment

Choose a reason for hiding this comment

jmagman commented Dec 13, 2022

jmagman Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

jmagman Dec 13, 2022

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

LabN36 commented Dec 16, 2022 • edited Loading

LabN36 commented Dec 16, 2022 • edited Loading

jmagman commented Dec 16, 2022

jmagman commented Dec 16, 2022

vashworth commented Dec 16, 2022

vashworth commented Dec 8, 2022 •

edited

Loading

jmagman Dec 13, 2022 •

edited

Loading

LabN36 commented Dec 16, 2022 •

edited

Loading

LabN36 commented Dec 16, 2022 •

edited

Loading