This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] White line after resize - fixed by adding floor() #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nkmrh, Everything looks good! Do you mind updating to the most current commit? Also can you update the version in |
|
Hi @nkmrh, Sorry, could you merge one more time. I'll push your code as soon as you do. It looks like you just need the version to 0.4.9 instead. |
bparrishMines
approved these changes
Aug 29, 2018
teriyakijack
added a commit
to teriyakijack/plugins
that referenced
this pull request
Aug 31, 2018
* upstream/master: Update FOSDC config (flutter#751) Add support-v4 dep to ml-vision (flutter#750) Add support for firebaseopensource.com (flutter#749) Use api to allow support-v4 version resolution. (flutter#748) Depend on full support-v4 library for ease of use (flutter#747) Plugin template for webview_flutter (flutter#746) Fix Java lint warnings in google maps plugin (flutter#745) Remove iOS instructions from the maps plugin readme. (flutter#744) [image_picker] White line after resize - fixed by adding floor() (flutter#686) Port google_maps_flutter to use AndroidView for embedding the map. (flutter#743)
nichtverstehen
pushed a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…r() (flutter#686)" This reverts commit d7a3205.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After resizing the image, I noticed a white line on the right or bottom.
I fixed it by truncating the decimal part of width and height.