-
Notifications
You must be signed in to change notification settings - Fork 9.8k
image_picker: Depend on full support-v4 library for ease of use #747
Conversation
I feel like a total noob over here but can I grab this PR as a dependency in my pubspec before it's accepted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
@calebisstupid I don't think you can do that, but the fix is live on pub now. |
@calebisstupid For future reference: dependencies:
flutter:
sdk: flutter
image_picker:
git:
url: git://github.com/sir-boformer/plugins.git
ref: revert-deps
path: packages/image_picker |
@sir-boformer TIL. Cool! |
* upstream/master: Update FOSDC config (flutter#751) Add support-v4 dep to ml-vision (flutter#750) Add support for firebaseopensource.com (flutter#749) Use api to allow support-v4 version resolution. (flutter#748) Depend on full support-v4 library for ease of use (flutter#747) Plugin template for webview_flutter (flutter#746) Fix Java lint warnings in google maps plugin (flutter#745) Remove iOS instructions from the maps plugin readme. (flutter#744) [image_picker] White line after resize - fixed by adding floor() (flutter#686) Port google_maps_flutter to use AndroidView for embedding the map. (flutter#743)
Thanks for the help! So I've got 0.4.10 now, but I am seeing the following:
I should add, it appears to be working when I added the following to my build.gradle file:
Searched a bit on this and unfortunately do not know enough about gradle to fully grasp why exactly this works (I'm coming to flutter from more iOS experience), and whether or not this is a workaround or a real fix. Any chance I could get a ELI5 on what exactly this is referring to? |
Does the issue still occur in image_picker 0.4.11? It was published a few hours ago. Does adding this to your build.gradle fix the problem? dependencies {
...
implementation 'com.android.support:support-v4:27.1.1'
} Can you post your full build.gradle (the one in the app folder) and your pubspec.yaml dependencies? |
I'll give 0.4.11 a shot. What is weird is an older flutter app I opened and migrated to 0.6.0 (also using image_picker 0.4.10) does not have this issue. Both projects were created with the standard flutter project creator. I'm just failing at isolating the cause. Adding For the project causing this issue:
build.gradle:
|
That's the wrong build.gradle. The one in your "app" folder... My first guess would be the location plugin. You would have to remove all plugins (plugin means flutter libraries which access native OS features) and enable them one by one to find the culprit. Or just keep the workaround in place... |
Ok cool. Adding I did toggle each plugin in and out and this was only occuring with image_picker. I'll keep this |
Adding this in case it helps with anything: I went to do a release build of the working app (working as in debug running fine) and got
Ended up adding the same |
This reverts commit 71cf8a4.
Partially fixes flutter/flutter#21173
@goderbauer