This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Rebuild VideoPlayer once VideoPlayerController finishes initialization. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtverstehen
force-pushed
the
master
branch
from
012e188
to
bcc75df
Compare
Otherwise if VideoPlayer is built shortly after the controller starts initialization and doesn't yet have _textureId filled the widgets renders as an empty Container and never rebuilds to show the video later.
nichtverstehen
force-pushed
the
master
branch
from
bcc75df
to
2d23f5f
Compare
sigurdm
approved these changes
Sep 6, 2018
...ages/video_player/android/src/main/java/io/flutter/plugins/videoplayer/QueuingEventSink.java
Outdated
Show resolved
Hide resolved
nichtverstehen
force-pushed
the
master
branch
from
2d23f5f
to
b1a1c43
Compare
This ensure that initialization events that are generated in `onPlayerStateChanged` before the Dart side has chance to subscribe to the channel are queued and eventually delivered. Fixes flutter/flutter#21483.
nichtverstehen
force-pushed
the
master
branch
from
b1a1c43
to
8c20b76
Compare
|
Updated the changelog and pubspec. |
|
Sigurd, are you able to merge this? |
|
Seems I still have access! |
|
I'll publish a new version as well |
|
Thank you! |
|
@nichtverstehen This breaks switching the Do you have any ideas why? Before I dig any deeper.. |
|
Oops, it's obvious in retrospect. We should react to |
nichtverstehen
added a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
…hanges. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization.
nichtverstehen
added a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
…hanges. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization.
|
Sent #769. |
nichtverstehen
added a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 7, 2018
…hanges. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization.
nichtverstehen
added a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 7, 2018
…hanges. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization.
sigurdm
pushed a commit
that referenced
this pull request
Sep 11, 2018
* Update textureId in VideoPlayer widget when the attached controller changes. This fixes a bug introduced in #767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization. * Add tests for conditions identified in flutter/flutter#21483. This is a breaking change since it reduces the public interface of VideoPlayerController to make it easier to fake it in the test (and hide unnecessary implementation details).
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…n. (flutter#767) * Rebuild VideoPlayer once VideoPlayerController finishes initialization. Otherwise if VideoPlayer is built shortly after the controller starts initialization and doesn't yet have _textureId filled the widgets renders as an empty Container and never rebuilds to show the video later. * Queue VideoPlayer events in the EventSink. This ensure that initialization events that are generated in `onPlayerStateChanged` before the Dart side has chance to subscribe to the channel are queued and eventually delivered. Fixes flutter/flutter#21483.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…er#769) * Update textureId in VideoPlayer widget when the attached controller changes. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization. * Add tests for conditions identified in flutter/flutter#21483. This is a breaking change since it reduces the public interface of VideoPlayerController to make it easier to fake it in the test (and hide unnecessary implementation details).
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…alization. (flutter#767)" This reverts commit 278e7ec.
ryanheise
pushed a commit
to ryanheise/background_video_player
that referenced
this pull request
Sep 29, 2019
* Update textureId in VideoPlayer widget when the attached controller changes. This fixes a bug introduced in flutter/plugins#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization. * Add tests for conditions identified in flutter/flutter#21483. This is a breaking change since it reduces the public interface of VideoPlayerController to make it easier to fake it in the test (and hide unnecessary implementation details).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the races in VideoPlayer plugin initialization.