-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Update VideoPlayer widget when the attached controller changes #769
Conversation
3265117
to
9b871c9
Compare
Also added tests for both conditions. |
1e08799
to
417b6dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a version bump/CHANGELOG update.
This change seems to be breaking the interface (though for the better).
Is it possible to first make a non-breaking fix that is version compatible?
You mean, keep |
Yes. |
417b6dd
to
8939b58
Compare
Updated the changes. There are two commits: the first one fixes the bug, the second one changes the interface and introduces the test. I put a minor version bump in the bugfix change (to 0.6.6) and bumped the major version number to 0.7.0 in the second CL (the test + the breaking API change aiding with the test). What do you think? |
…hanges. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization.
This is a breaking change since it reduces the public interface of VideoPlayerController to make it easier to fake it in the test (and hide unnecessary implementation details).
8939b58
to
1ea0bd5
Compare
(Updated the CHANGELOG too.) |
The commits LGTM, but I can only land a squashed commit, so it has to be two PRs :(. |
I am going on weekend now. So if you need to land this urgent you need to find another reviewer. |
The currently published video_player is broken. It would be nice if this could be merged as soon as possible. @sigurdm are you back from the weekend? |
I published a new version on pub |
Sorry, it was a long weekend in Zurich, so didn't get to split the PR. Thank you for taking care of this, Sigurd! |
I haven't made the split, just published the full thing. Let's hope that's good enough. |
…er#769) * Update textureId in VideoPlayer widget when the attached controller changes. This fixes a bug introduced in flutter#767: if a State is attached to a new widget it never switched to the new controller. Also this change makes sure to remove listeners during deinitialization. * Add tests for conditions identified in flutter/flutter#21483. This is a breaking change since it reduces the public interface of VideoPlayerController to make it easier to fake it in the test (and hide unnecessary implementation details).
flutter#769)" This reverts commit f146794.
This fixes a bug introduced in #767: if a State is attached to a new widget it never switched to the new controller.
Also this change makes sure to remove listeners during deinitialization.