This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_auth] adding return to verifyPhoneNumber #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kroikie , I guess this is a quick one. I didn't improve the tests because the current plugin mockup simulates exactly what the real plugin didn't do until this PR, which is returning null. So regarding this aspect the test is now compatible with the implementation. |
|
Looks good, thank you! |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit bcb58e0.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#23332
verifyPhoneNumber()is supposed to be used with the callbacks passed in its arguments.However, this method returns
Future<void>, and usingawait verifyPhoneNumber(...)hangs as neither Android or iOS implementations ever return anything for this method call.Adding a
nullreturn so that the method returns after the callbacks are registered.