-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Veggie Seasons UI doesn't handle dark mode well #322
Comments
I have started working on the fix for this issue. Eg:
Will turn into:
Do you think this is a good solution? Or is there a better solution? |
To be quite honest, the way I originally set up the fonts and colors in Veggieseasons was not a great architecture. A lot of the support for theming in Cupertino didn't exist 12-16 months ago when the app was written. Now, though, it should be possible to use CupertinoTextThemeData: And CupertinoThemeData: to do the job right. If you look at an app like the Material Gallery, rather than having a file that sets up a bunch of font/color constants, it has a file that constructs its ThemeData objects for light and dark theme: https://github.com/flutter/gallery/blob/master/lib/themes/gallery_theme_data.dart This app could do the same thing, and set up some base text styles that work in a number of places, and then modify them as needed in particular widgets (to tweak font weight or whatever). There would still be some colors, gradients, and so on remaining in that styles file, but a lot of the text styling could be pulled out and "done right," so to speak. So, while the change you're suggesting would work, there's an opportunity here to improve the app in a more fundamental way. Since these apps are meant to serve as examples of the best ways to do things with Flutter, that's really where we should be aiming. If that's more work than you were looking to contribute, I completely understand, but I do feel it's the right way to go here. |
Hi, I'd like to try this. Quick question: Thanks |
@RedBrogdon, I think we can close this issue now. |
I believe so. |
Title says it all. We need to update the app to deal with iOS's dark mode properly rather than displaying black-on-black text in several places within the app.
The text was updated successfully, but these errors were encountered: