Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform_design] Some of the UI elements turn invisible in dark mode #376

Closed
abd99 opened this issue Mar 16, 2020 · 5 comments
Closed

[platform_design] Some of the UI elements turn invisible in dark mode #376

abd99 opened this issue Mar 16, 2020 · 5 comments

Comments

@abd99
Copy link
Contributor

abd99 commented Mar 16, 2020

I found the following issues in the platform_design app:

  • The Settings show black on black text in dark mode.
  • There are a couple of more widgets that don't go well with the dark mode throughout the app.

Screenshots:
Screenshot_20200317-000736
Screenshot_20200317-000747

I'm currently working on the solution.

I've read the contribution guide but this is my first PR in a big repo. So, please bear with me.
I'm thinking of just changing color to grab from the theme wherever it is hardcoded.

Let me know what you think of it @RedBrogdon @johnpryan @domesticmouse

@jddeep
Copy link
Contributor

jddeep commented Mar 17, 2020

This has been an issue for the iOS version of VeggieSeasons app as well. There is already an issue open about that #322. @RedBrogdon should we toggle the app font/text colors with respect to the app theme brightness(light or dark).

@RedBrogdon
Copy link
Contributor

RedBrogdon commented Mar 17, 2020

Thanks for filing an issue, @abd99. There are a few things that should happen here:

  1. Audit all the apps in the repo to make sure there aren't any others with dark mode problems, and file issues for them.
  2. Hard-code a bright theme for any that do, this app included. See Disable dark mode for Veggieseasons #340 for how this was done for Veggieseasons.
  3. Update each of those apps to properly respect dark mode.

That third task is the hardest, and for each app it should be done in several PRs rather than just one big one. It's too large a change to review otherwise.

@abd99
Copy link
Contributor Author

abd99 commented Mar 23, 2020

As per your suggestion @RedBrogdon, I have checked all the apps in the repo except for web and experimental apps for dark mode problems. As of now, none of the apps have that problem except for VeggieSeasons(which you solved temporarily). Most of them don't even support dark mode. Let me know if you want me to add dark mode support to any of them. I have started working on the fix for VeggieSeasons and have shared the solution I'm opting for in #322. Please let me know what you think of it.

@RedBrogdon
Copy link
Contributor

@abd99, is there any remaining short-term work for VeggieSeasons now that #322 is merged? I believe we can go ahead and close this if not.

@abd99
Copy link
Contributor Author

abd99 commented Mar 31, 2020

Sure, I think we are good for now with this issue. I'll close it.

@abd99 abd99 closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants