-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform_design] Some of the UI elements turn invisible in dark mode #376
Comments
This has been an issue for the iOS version of VeggieSeasons app as well. There is already an issue open about that #322. @RedBrogdon should we toggle the app font/text colors with respect to the app theme brightness(light or dark). |
Thanks for filing an issue, @abd99. There are a few things that should happen here:
That third task is the hardest, and for each app it should be done in several PRs rather than just one big one. It's too large a change to review otherwise. |
As per your suggestion @RedBrogdon, I have checked all the apps in the repo except for web and experimental apps for dark mode problems. As of now, none of the apps have that problem except for VeggieSeasons(which you solved temporarily). Most of them don't even support dark mode. Let me know if you want me to add dark mode support to any of them. I have started working on the fix for VeggieSeasons and have shared the solution I'm opting for in #322. Please let me know what you think of it. |
Sure, I think we are good for now with this issue. I'll close it. |
I found the following issues in the platform_design app:
Screenshots:
I'm currently working on the solution.
I've read the contribution guide but this is my first PR in a big repo. So, please bear with me.
I'm thinking of just changing color to grab from the theme wherever it is hardcoded.
Let me know what you think of it @RedBrogdon @johnpryan @domesticmouse
The text was updated successfully, but these errors were encountered: