Update add to app android_view to api 35 #2368
Merged
+37
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
approved these changes
Jul 26, 2024
|
Running the ci script locally passes for me and @gmackall. Running the tasks involved also do not seem to error. @ericwindmill can you think of anything else I should try to figure out why this is failing only in ci? |
ericwindmill
approved these changes
Jul 29, 2024
|
Current theory: The failure might be flutter version dependent. I will check out the previous stable and see if I can reproduce. |
|
Confirmed that this is broken on 3.22.3 and fixed on master. Also spoke with @ericwindmill out of band who gave the ok to merge anyway since the examples normally need to be updated when there is a new flutter version (which is happening shortly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/n flutter/flutter#152374
Pre-launch Checklist
///).