Rename Navigator 2.0 to Router #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns better with the documentation for this new API, and doesn't imply that apps need to be upgraded.
chunhtai
approved these changes
Feb 9, 2021
navigation_and_routing/README.md
Outdated
|
|
||
| ## Samples | ||
|
|
||
| **Navigator 1.0 samples** | ||
| **Introductory samples** |
There was a problem hiding this comment.
Introductory samples sounds a bit weird, Maybe just Navigator samples?
There was a problem hiding this comment.
I think that makes sense, I was concerned that it might be misleading to call these Navigator samples, since Router works alongside Navigator too
There was a problem hiding this comment.
I have no strong opinion on this maybe you can add something like existing navigator sample or imperative navigator example but then you will need to explain what imperative is....
There was a problem hiding this comment.
Me neither, I'll change this to navigator
RedBrogdon
approved these changes
Feb 11, 2021
filiph
pushed a commit
that referenced
this pull request
Feb 18, 2021
* update sample to use new versions (#702) * Fixed Typo in add-to-app/README.md (#706) * Fix cookbook scraper bugs and re-run (#697) * fix path separator bug in cookbook scraper * update lockfiles * add category to image name to avoid conflicts e.g. testing/integration/introduction testing/widget/introduction * fix form_app symlink * remove webimages directory * remove vision_challenge vision_challenge doesn't build on the dev channel * update pubspec.yaml in _tool and form_app * Added sample code for multiple flutters on iOS (#670) * Update link (#709) * Adjust pubspecs (#713) * Update file header date in contributing.md (#714) * Added Focusnodes in form sample (#707) * Rename Navigator 2.0 to Router (#712) * Rename Navigator 2.0 to Router This aligns better with the documentation for this new API, and doesn't imply that apps need to be upgraded. * introduction -> navigator * [animations] added test for focus image (#711) * Removed hardcoded NDK version for android_fullscreen (#717) Co-authored-by: Ayush Bherwani <ayush.bherwani1998@gmail.com> Co-authored-by: Swayam221 <68892315+Swayam221@users.noreply.github.com> Co-authored-by: John Ryan <ryjohn@google.com> Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Co-authored-by: Utkarsh Shendge <utkarshcpark@gmail.com> Co-authored-by: Michael Thomsen <mit@google.com> Co-authored-by: Daniel Etuk <77677996+0xdanny@users.noreply.github.com> Co-authored-by: Alabhya <singhalabhya32@gmail.com> Co-authored-by: Arteev Raina <arteevraina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns better with the documentation for this new API, and doesn't imply that apps need to be upgraded.
cc: @chunhtai