Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update super editor hash to the latest commit #351

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Update super editor hash to the latest commit #351

merged 1 commit into from
Mar 11, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Mar 9, 2024 •
edited

This PR is to update super editor tests to the latest commit with the fix related to flutter/flutter#144180.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@QuncCccccc QuncCccccc marked this pull request as ready for review March 11, 2024 18:21
@QuncCccccc QuncCccccc requested a review from Piinks March 11, 2024 18:22
Piinks
Piinks approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 9908aaf into main Mar 11, 2024
12 checks passed
@auto-submit auto-submit bot deleted the update_super_editor_hash branch March 11, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit
Projects
None yet
Milestone
No milestone
2 participants
@QuncCccccc @Piinks