Remove `showTrackOnHover` from `Scrollbar` and `ScrollbarTheme` #144180

QuncCccccc · 2024-02-26T22:42:48Z

This PR is to remove deprecated Scrollbar.showTrackOnHover and ScrollbarThemeData.showTrackOnHover.

These parameters are made obsolete in #111706.
Part of #143956

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

QuncCccccc · 2024-03-06T20:42:00Z

This one is ready to review but might need to merge the super editor one first to fix the customer testing:)

Piinks

LGTM! Yes, super editor will need to migrate first before this can land. 👍

This PR is to update super editor tests to the latest commit with the fix related to flutter/flutter#144180.

…eme` (flutter/flutter#144180)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. labels Feb 26, 2024

QuncCccccc marked this pull request as ready for review March 6, 2024 20:42

QuncCccccc requested a review from Piinks March 6, 2024 20:42

Piinks approved these changes Mar 6, 2024

View reviewed changes

QuncCccccc mentioned this pull request Mar 8, 2024

Remove deprecated showTrackOnHover superlistapp/super_editor#1851

Merged

QuncCccccc force-pushed the remove_show_track_on_hover branch 2 times, most recently from fccd4fc to 6727343 Compare March 9, 2024 01:22

QuncCccccc mentioned this pull request Mar 9, 2024

Update super editor hash to the latest commit flutter/tests#351

Merged

8 tasks

auto-submit bot pushed a commit to flutter/tests that referenced this pull request Mar 11, 2024

Update super editor hash to the latest commit (#351)

9908aaf

This PR is to update super editor tests to the latest commit with the fix related to flutter/flutter#144180.

QuncCccccc force-pushed the remove_show_track_on_hover branch 2 times, most recently from 34a1682 to a9ebf04 Compare March 12, 2024 17:02

QuncCccccc added 5 commits March 13, 2024 00:21

Remove showTrackOnHover from Scrollbar and ScrollbarTheme

af16525

Update unit test

0bce294

Update unit tests

b658ec7

Trigger tests

ebdc96e

Re-trigger Google testing

227e6c0

QuncCccccc force-pushed the remove_show_track_on_hover branch from 2c4f3bd to 227e6c0 Compare March 13, 2024 07:21

Rebuild

995f75d

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2024

auto-submit bot merged commit 1ccad1a into flutter:master Mar 13, 2024
67 checks passed

engine-flutter-autoroll mentioned this pull request Mar 13, 2024

Roll Flutter from 61812ca3eb13 to 1ccad1a2a7fb (27 revisions) flutter/packages#6314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

9d04675

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 13, 2024

Roll Flutter from 61812ca3eb13 to 017f33df6c23 (29 revisions) flutter/packages#6315

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

2ae86ab

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 13, 2024

Roll Flutter from 61812ca3eb13 to b9e537336f0b (30 revisions) flutter/packages#6316

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

3ab1147

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 13, 2024

Roll Flutter from 61812ca3eb13 to 122849311ffd (32 revisions) flutter/packages#6317

Closed

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to 3d5f786416c5 (47 revisions) flutter/packages#6323

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

0dac525

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to 5b7d5cadc164 (48 revisions) flutter/packages#6324

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

6dea41b

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to 51d59a7d1e79 (49 revisions) flutter/packages#6325

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

0e737ef

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to a69567a36f69 (50 revisions) flutter/packages#6326

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

e56a0c7

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to 9f5fd75e54fc (51 revisions) flutter/packages#6327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

dd6a6c2

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to 20889dd816bf (52 revisions) flutter/packages#6328

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

5d96adc

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to bc611f565b05 (53 revisions) flutter/packages#6329

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

e70c827

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 14, 2024

Roll Flutter from 394269f9ea2e to 2c5d3b05fa61 (54 revisions) flutter/packages#6330

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

3ba7a80

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 15, 2024

Manual roll Flutter from c01d7f069861 to 9b276be7fe98 (59 revisions) flutter/packages#6334

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

ba0e4bd

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 15, 2024

Roll Flutter from c01d7f069861 to 8d54abfc221e (61 revisions) flutter/packages#6336

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

d6fd5a6

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 15, 2024

Roll Flutter from c01d7f069861 to eeff96d4b3c3 (62 revisions) flutter/packages#6337

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

e1a4df6

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 15, 2024

Roll Flutter from c01d7f069861 to 58eb0e8ae630 (63 revisions) flutter/packages#6338

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

64b816c

…eme` (flutter/flutter#144180)

engine-flutter-autoroll mentioned this pull request Mar 15, 2024

Roll Flutter from c01d7f069861 to a97af2093b1a (64 revisions) flutter/packages#6340

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

b1cfb0a

…eme` (flutter/flutter#144180)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

b3aa877

…eme` (flutter/flutter#144180)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

f05f212

…eme` (flutter/flutter#144180)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

5bdbaa3

…eme` (flutter/flutter#144180)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

1ccad1a2a Remove showTrackOnHover from Scrollbar and `ScrollbarTh…

a41ba67

…eme` (flutter/flutter#144180)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `showTrackOnHover` from `Scrollbar` and `ScrollbarTheme` #144180

Remove `showTrackOnHover` from `Scrollbar` and `ScrollbarTheme` #144180

QuncCccccc commented Feb 26, 2024 •

edited

QuncCccccc commented Mar 6, 2024

Piinks left a comment

Remove showTrackOnHover from Scrollbar and ScrollbarTheme #144180

Remove showTrackOnHover from Scrollbar and ScrollbarTheme #144180

Conversation

QuncCccccc commented Feb 26, 2024 • edited

Pre-launch Checklist

QuncCccccc commented Mar 6, 2024

Piinks left a comment

Choose a reason for hiding this comment

Remove `showTrackOnHover` from `Scrollbar` and `ScrollbarTheme` #144180

Remove `showTrackOnHover` from `Scrollbar` and `ScrollbarTheme` #144180

QuncCccccc commented Feb 26, 2024 •

edited