Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate app-figure.md includes to render #10526

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented May 7, 2024

Contributes to #10525 by migrating all usages of app-figure.md to the newer render syntax instead of include, for improved encapsulation.

@parlough parlough changed the title Migrate app-figure.md include to render Migrate app-figure.md includes to render May 7, 2024
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented May 7, 2024

Visit the preview URL for this PR (updated for commit a5c832a):

https://flutter-docs-prod--pr10526-misc-app-figure-to-render-6uxw14ic.web.app

@parlough parlough added the review.copy Awaiting Copy Review label May 7, 2024
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but fix the link.

@parlough parlough removed the review.copy Awaiting Copy Review label May 7, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit e73c3fe into main May 8, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the misc/app-figure-to-render branch May 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants