Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout sizing example app #2301

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Layout sizing example app #2301

merged 1 commit into from
Jan 28, 2019

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 28, 2019

This PR contains edits to the "Sizing widgets" section. The main edits to the prose are:

  • Move the alert from the previous section (which talked about overflows), into the Sizing section.
  • Then present the fix to the overflow example, which is to use Expanded.
  • Finally show the "expanded" example that uses a flex factor of 2.

Contributes to #2233.

Staged at: https://flutter-io-staging-1.firebaseapp.com/docs/development/ui/layout#sizing-widgets


The updated section looks like this:

screen shot 2019-01-28 at 16 33 07

@chalin chalin requested a review from sfshaza2 January 28, 2019 21:35
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 28, 2019
The Expanded widget has a `flex` property, an integer that determines
the flex factor for a widget. The default flex factor for an Expanded
widget is 1.
When a layout is too large to fit a device, a yellow and black striped pattern
Copy link
Contributor

@sfshaza2 sfshaza2 Jan 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the yellow and black striping is new!

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit 8b5176b into master Jan 28, 2019
@chalin chalin deleted the chalin-layout-sizing-0128 branch January 28, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants