Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code excerpts: use new tooling and infra #2233

Closed
3 of 6 tasks
chalin opened this issue Jan 17, 2019 · 2 comments · Fixed by #7904
Closed
3 of 6 tasks

Code excerpts: use new tooling and infra #2233

chalin opened this issue Jan 17, 2019 · 2 comments · Fixed by #7904
Assignees
@chalin
Labels
cl.fixed Issue is closed as fixed e3-weeks Effort: < 4 weeks fix.examples Adds or changes example infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.

Comments

@chalin
Copy link
Contributor

chalin commented Jan 17, 2019 •
edited
Loading

We currently have two mechanisms for dealing with code fragments: the old approach (using Jekyll include on individual fragments) and the new (where fragments are excerpt from fully tested apps).

The Get Started codelab and the Building Layouts tutorial use the new mechanism. This issue will be used to track the updates of remaining pages.

  • Get Started codelab
  • Layouts tutorial
  • Layouts in Flutter
  • Animations
  • i18n
  • development/platform-integration/c-interop.md
@chalin chalin added infra.structure Relates to the tools that create docs.flutter.dev fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible. e3-weeks Effort: < 4 weeks labels Jan 17, 2019
@chalin chalin self-assigned this Jan 17, 2019
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Make old code excerpter ignore new <?code-excerpt?> blocks
15ddba0 
... w/o the need for <!-- skip --> comments. Contributes to #2233
@chalin chalin mentioned this issue Jan 17, 2019
Merged
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Make old code excerpter ignore new <?code-excerpt?> blocks (#2234)
ecbc9aa 
... w/o the need for <!-- skip --> comments. Contributes to #2233
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
f4192c5 
Contributes to #2233
@chalin chalin mentioned this issue Jan 17, 2019
Merged
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
4f1ab0c 
Contributes to #2233
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
ee93f9b 
Contributes to #2233
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
65c0920 
Contributes to #2233
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
75dc0b2 
Contributes to #2233
chalin added a commit that referenced this issue Jan 17, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
12d08c7 
Contributes to #2233
chalin added a commit that referenced this issue Jan 18, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
1ea7fdf 
Contributes to #2233
chalin added a commit that referenced this issue Jan 21, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts
2232e5c 
Contributes to #2233
chalin added a commit that referenced this issue Jan 23, 2019
@chalin
Rework of "Lay out a widget" + use of code-excerpts (#2235)
03d384f 
Contributes to #2233
@chalin chalin mentioned this issue Jan 24, 2019
Merged
chalin added a commit that referenced this issue Jan 28, 2019
@chalin
Layout row app + tests
1dedb4d 
Contributes to #2233
@chalin chalin mentioned this issue Jan 28, 2019
Merged
chalin added a commit that referenced this issue Jan 28, 2019
@chalin
Layout row app + tests
d646d2a 
Contributes to #2233
chalin added a commit that referenced this issue Jan 28, 2019
@chalin
Layout row app + tests (#2294)
904127f 
Contributes to #2233
This was referenced Jan 28, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@chalin chalin mentioned this issue Jan 29, 2019
Merged
chalin added a commit that referenced this issue Jan 30, 2019
@chalin
Layout example: Card and Stack
f38510e 
Contributes to #2233, #2279
@chalin chalin mentioned this issue Jan 30, 2019
Merged
chalin added a commit that referenced this issue Jan 30, 2019
@chalin
Layout example: Card and Stack (#2314)
eefbd4b 
Contributes to #2233, #2279
@chalin
Copy link
Contributor Author

chalin commented Jan 30, 2019

Done with all the Development > UI > Layout pages.

This was referenced Jan 31, 2019
Merged
Closed
Merged
chalin added a commit that referenced this issue Oct 9, 2019
@chalin
C-interop: don't try to analyze incomplete code fragmennts
2dc3ebb 
Contributes to #3076 by ensuring that code checks pass for the c-interop page.
Also some minor markdown cleanup.

Mainly add `<!-- skip -->` directives. We'll be able to drop these directives and actually check the code once we're done with #2233.
@chalin chalin mentioned this issue Oct 9, 2019
Merged
sfshaza2 pushed a commit that referenced this issue Oct 10, 2019
@chalin @sfshaza2
C-interop: don't try to analyze incomplete code fragmennts (#3077)
989b7be 
Contributes to #3076 by ensuring that code checks pass for the c-interop page.
Also some minor markdown cleanup.

Mainly add `<!-- skip -->` directives. We'll be able to drop these directives and actually check the code once we're done with #2233.
@chalin chalin mentioned this issue Oct 11, 2019
Closed
@chalin chalin added p1-high Major but not urgent concern: Resolve in months. Update each month. and removed p2-medium Necessary but not urgent concern. Resolve when possible. labels Oct 11, 2019
@chalin
Copy link
Contributor Author

chalin commented Oct 11, 2019

With @sfshaza2's blessing, promoting to P1 to match the companion P1 #3076.

@chalin chalin mentioned this issue Oct 11, 2019
Closed
23 tasks
@parlough parlough mentioned this issue Dec 3, 2022
Merged
3 tasks
@danagbemava-nc danagbemava-nc added the cl.fixed Issue is closed as fixed label Dec 6, 2022
@parlough parlough mentioned this issue Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
cl.fixed Issue is closed as fixed e3-weeks Effort: < 4 weeks fix.examples Adds or changes example infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove remnants of old snippet extraction functionality parlough/website
2 participants
@chalin @danagbemava-nc