Allow check-code.sh to check code again #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `check-code.sh` doesn't pretty much nothing. Move `--no-check-code` option from the check-code.sh script into Travis config so that we can run check-code.sh manually over a local repo. This PR has no net change relative to the Travis build.
chalin
added
the
infra.structure
googlebot
added
the
cla: yes
legalcodes
approved these changes
Oct 9, 2019
|
Contributes to #3076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
check-code.shdoesn't pretty much nothing. Move the--no-check-codeoption from the check-code.sh script into Travis config so that we can runcheck-code.shmanually over a local repo and have it actually check code once again. This PR has no net change relative to the Travis build.This PR is a small step toward reinstating CI code checks.
cc @johnpryan