Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: ensure that example code is analyzed and tested #3076

Closed
chalin opened this issue Oct 9, 2019 · 7 comments
Closed

CI: ensure that example code is analyzed and tested #3076

chalin opened this issue Oct 9, 2019 · 7 comments
Assignees
@chalin
Labels
e2-days Effort: < 5 days infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.

Comments

@chalin
Copy link
Contributor

chalin commented Oct 9, 2019 •
edited
Loading

Reinstate code checks that were temporarily disabled by #2738:

Related:
@chalin chalin added the infra.structure Relates to the tools that create docs.flutter.dev label Oct 9, 2019
@chalin chalin self-assigned this Oct 9, 2019
@chalin chalin mentioned this issue Oct 9, 2019
Merged
chalin added a commit that referenced this issue Oct 9, 2019
@chalin
C-interop: don't try to analyze incomplete code fragmennts
2dc3ebb 
Contributes to #3076 by ensuring that code checks pass for the c-interop page.
Also some minor markdown cleanup.

Mainly add `<!-- skip -->` directives. We'll be able to drop these directives and actually check the code once we're done with #2233.
This was referenced Oct 9, 2019
Merged
Merged
sfshaza2 pushed a commit that referenced this issue Oct 10, 2019
@chalin @sfshaza2
C-interop: don't try to analyze incomplete code fragmennts (#3077)
989b7be 
Contributes to #3076 by ensuring that code checks pass for the c-interop page.
Also some minor markdown cleanup.

Mainly add `<!-- skip -->` directives. We'll be able to drop these directives and actually check the code once we're done with #2233.
@sfshaza2 sfshaza2 added e2-days Effort: < 5 days p1-high Major but not urgent concern: Resolve in months. Update each month. labels Oct 11, 2019
@chalin chalin mentioned this issue Oct 11, 2019
Closed
6 tasks
@chalin chalin changed the title CI: ensure that example code is analyzed and test CI: ensure that example code is analyzed and tested Oct 11, 2019
@chalin chalin mentioned this issue Oct 11, 2019
Closed
23 tasks
@chalin
Copy link
Contributor Author

chalin commented Apr 7, 2020

The problem is that Travis Ubuntu uses GNU diff 3.x and macOS is still at 2.x (the macOS version is very old).

chalin added a commit to chalin/website that referenced this issue Apr 7, 2020
@chalin
README: add diffutils 3.6+ as prerequisite
1a9624d 
Contributes to flutter#3076
@chalin chalin mentioned this issue Apr 7, 2020
Merged
@sfshaza2
Copy link
Contributor

sfshaza2 commented Apr 7, 2020

@dnfield

@chalin
Copy link
Contributor Author

chalin commented Apr 7, 2020

#3916 updates the README. Maybe you'd like a simple diff version check added to tool/refresh-code-excerpts.sh before closing this issue?

sfshaza2 pushed a commit that referenced this issue Apr 7, 2020
@chalin
README: add diffutils 3.6+ as prerequisite (#3916)
e64fb81 
Contributes to #3076
@chalin
Copy link
Contributor Author

chalin commented Apr 8, 2020

For the record, I did check diff behavior differences across OSs when this problem surfaced. I'm not sure why I concluded that the diff tool wasn't the issue back then. That kinda set me on a wild goose chase :-/. Anyhow, thanks to @dnfield for again suggesting that it might be a diff tool issue. Taking a second look did the trick -- actually having access to a Linux box helped make the investigation much easier!

@sfshaza2
Copy link
Contributor

sfshaza2 commented Apr 8, 2020

Can this be closed?

@chalin
Copy link
Contributor Author

chalin commented Apr 10, 2020

Depends if you'd like a version check added to the refresh script, for example.

@sfshaza2
Copy link
Contributor

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
e2-days Effort: < 5 days infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chalin @sfshaza2