Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broken (possibly old?) Step #4 #3211

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

chonghorizons
Copy link
Contributor

Replace broken (possibly old?) Step #4 with a correct version from the completed example. No code added, just fixing an internal consistency on the page.

I've tested the completed example in Android Studio and it runs with no errors.

From the Cookbooks, so it's a high-visibility doc.
Fixes #3209

Replace broken (possibly old?) Step flutter#4 with a correct version from the completed example.
I've tested the completed example in Android Studio and it runs with no errors.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Nov 6, 2019
@chonghorizons
Copy link
Contributor Author

@googlebot I signed it!

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Nov 6, 2019
@johnpryan johnpryan merged commit 49124fd into flutter:master Nov 7, 2019
Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chonghorizons
Copy link
Contributor Author

LGTM, thanks!

Actually, I think we might want to unmerge this pull request. Or the page needs some rewriting.

Now there is an inconsistency with the text in Step 4. (https://flutter.dev/docs/cookbook/navigation/navigate-with-arguments#4-navigate-to-the-widget)
It references pushNamed but the code I added didn't have used push.

And step 3 isn't in the completed example.

Someone (maybe me) should try to rewrite the page.

@johnpryan
Copy link
Contributor

Thanks for pointing that out - creating an issue since this requires a bit more work: #3245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COOKBOOK: Completed Doesn't Match Step 4, also won't run. 'Pass arguments to a named route' page issue
3 participants