-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace broken (possibly old?) Step #4 #3211
Conversation
Replace broken (possibly old?) Step flutter#4 with a correct version from the completed example. I've tested the completed example in Android Studio and it runs with no errors.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Actually, I think we might want to unmerge this pull request. Or the page needs some rewriting. Now there is an inconsistency with the text in Step 4. (https://flutter.dev/docs/cookbook/navigation/navigate-with-arguments#4-navigate-to-the-widget) And step 3 isn't in the completed example. Someone (maybe me) should try to rewrite the page. |
Thanks for pointing that out - creating an issue since this requires a bit more work: #3245 |
Replace broken (possibly old?) Step #4 with a correct version from the completed example. No code added, just fixing an internal consistency on the page.
I've tested the completed example in Android Studio and it runs with no errors.
From the Cookbooks, so it's a high-visibility doc.
Fixes #3209