Flutter Stager #416

FaisalAbid · 2017-03-06T07:39:29Z

Addresses the issue flutter/flutter#8159

How it works

There are 10 Firebase projects setup.
There is a Master Firebase Project Setup with Firebase Database that coordinates everything
When a PR is made, we find a free firebase project and deploy it, storing what branch was deployed on which PR
When an update to a PR is made, we find the project that was associated with that PR and return that
It finds the Pull Request Issue and makes a comment from a bot account with the URL to that staging url.
This scales well by just adding more entries to the Firebase Database
We do a cleanup when it runs by checking the branches currently in the database still exist as Pull requests, if no then we delete the entry and let something else override it

Please review!

I would also like to point out the following line, would like someones thoughts on this, is there a better way to do this?
if [ "$BRANCH" != "master" ]; then

Please ask questions if something is unclear of if something needs to be documented more.

I will be providing @sethladd with the access tokens as well as project access to all the firebase projects shortly.

FaisalAbid · 2017-03-06T07:40:33Z

Sample deploy url https://fir-deploy-one.firebaseapp.com

FaisalAbid · 2017-03-06T07:52:19Z

Fixing up a oAuth issue with the firebase token, will update PR shortly

sethladd · 2017-03-06T20:37:30Z

What does "fir" mean? Just curious...

FaisalAbid · 2017-03-06T20:38:07Z

@sethladd I created the projects as firebase-deploy-one and Firebase converts the name "firebase" to fir lol

sethladd · 2017-03-06T20:38:31Z

tool/pubspec.yaml

+version: 0.0.1
+dependencies:
+  firebase: '3.0.0'
+  github: 'any'


please lock to a version with ^

sethladd · 2017-03-06T20:38:55Z

tool/travis.sh

@@ -82,3 +84,16 @@ if [ "$TRAVIS_EVENT_TYPE" = "push" ] && [ "$TRAVIS_BRANCH" = "master" ]; then
  npm install --global firebase-tools@3.0.0
  firebase -P sweltering-fire-2088 --token "$FIREBASE_TOKEN" deploy
 fi
+
+if [ "$BRANCH" != "master" ]; then
+    echo "deploying to test environment"


maybe "to staging environment" instead of "test environment" ?

sethladd · 2017-03-06T20:40:11Z

tool/prdeployer.dart

@@ -0,0 +1,90 @@
+// Copyright (c) 2017, FaisalAbid. All rights reserved. Use of this source code


Did you run the formatter over this?

I have webstorm to auto format the entire file on save, i'll fix this issue

Also, please update the copyright :)

And then please add yourself to the AUTHORS file. Which, if it doesn't exist, please add it :)

Ah yes ofcourse!

~~The AUTHORS file exists, it's in the root of the repo. The copyright on every other file should be identical (that's what the CLA you signed is about :-) ).~~

Disregard, turns out we've screwed this up.

sethladd · 2017-03-06T20:41:05Z

Oh, weird. Would it make more sense to use flutter-io-staging-one, etc ?

FaisalAbid · 2017-03-06T20:41:36Z

Sure! just a matter of renaming the projects, I can do that easily

a14n · 2017-03-07T08:25:11Z

tool/prdeployer.dart

+
+main(List<String> arguments) async {
+  String branchName = arguments[0];
+  Map env = Platform.environment;


generics Map<String, String>

a14n · 2017-03-07T08:26:38Z

tool/prdeployer.dart

+  return true;
+}
+
+Future<List> getPullRequests() async {


generics: Future<List<PullRequest>>

a14n · 2017-03-07T08:26:49Z

tool/prdeployer.dart

+
+Future<List> getPullRequests() async {
+  Stream<PullRequest> prs = await github.pullRequests.list(new RepositorySlug.full("flutter/website"));
+  List prsList = await prs.toList();


generics: List<PullRequest>

a14n · 2017-03-07T08:27:10Z

tool/prdeployer.dart

+}
+
+Future<bool> isBranchOld(String branchName) async {
+  List prsList = await getPullRequests();


generics: List<PullRequest>

a14n · 2017-03-07T08:27:41Z

tool/prdeployer.dart

+
+  FirebaseClient fbClient = new FirebaseClient(firebaseAuth);
+
+  List prsList = await getPullRequests();


generics: List<PullRequest>

a14n · 2017-03-07T08:30:07Z

tool/prdeployer.dart

+
+GitHub github;
+String firebaseAuth;
+PullRequest currentPullrequest;


currentPullrequest -> currentPullRequest

a14n · 2017-03-07T08:30:16Z

tool/prdeployer.dart

+      currentPullrequest = p;
+      break;
+    }
+  }


instead of for loop: currentPullRequest = prsList.firstWhere((p) => p.head.ref == branchName);

Love this, thanks @a14n - great idea

a14n · 2017-03-07T08:48:31Z

tool/prdeployer.dart

+      return false;
+    }
+  }
+  return true;


same as: return !prsList.any((p) => p.head.ref == branchName); ?

sethladd · 2017-03-08T04:40:33Z

tool/prdeployer.dart

+    });
+  }
+
+  print(projectToDeploy);


should we add more context to the print? Or is printing the name sufficiently useful?

The print value is used in travis.sh to populate firebase deploy, so it just needs to be on its own

sethladd · 2017-03-08T04:42:13Z

tool/prdeployer.dart

+}
+
+Future<bool> isBranchOld(String branchName) async {
+  List<PullRequest> prsList = await getPullRequests();


style nit: do we have to use the type name in the variable name? prsList or just pullRequests ?

sure i can rename it to pullRequests

sethladd · 2017-03-08T04:44:28Z

What's the risk of landing this and living with it for a little while?

FaisalAbid · 2017-03-08T04:46:51Z

No risk, GitHub flagged my Bot account since there was no activity on it, I emailed them to get it reactivated, once that is up we can merge this.

In my tests on my private Travis its worked well, staged it, sent out the comment etc.

sethladd · 2017-03-08T04:50:24Z

Let's try merging this tomorrow (not at night time here :) and seeing how it works.

FaisalAbid · 2017-03-08T04:51:38Z

Great, Github will have replied back to me by then too. Excited!

FlutterBot · 2017-03-08T05:18:12Z

Test comment

sethladd · 2017-03-08T17:22:55Z

Let me know when we can merge this. I see Travis is red, not sure that's expected.

FaisalAbid · 2017-03-08T17:32:39Z

Travis is red because of flutter/flutter#8646

FlutterBot · 2017-03-09T21:39:02Z

Staging URL Generated At https://flutter-io-deploy-one.firebaseapp.com . Please allow Travis Build to finish to view the URL.

FaisalAbid · 2017-03-09T21:40:35Z

@sethladd yay worked, flutter-bot even wrote the comment!

sethladd · 2017-03-09T21:48:49Z

Wow, very cool! Once Travis goes all green, we can merge and watch what happens.

FYI @LarkAscending @Sfshaza

LarkAscending · 2017-03-10T02:40:30Z

Travis website builds are failing for #431 and #432.

log

Error: Command requires authentication, please run firebase login

upstream error:

Unauthorized request.
#0      FirebaseClient.send (package:firebase/firebase_io.dart:95:11)

Could this be a dependency issue? Neither @cbracken nor @LarkAscending has the dependencies installed for FB CLI.

FaisalAbid · 2017-03-10T03:16:07Z

Thats weird that it's seeing a Google oauth issue, im investigating why

LarkAscending · 2017-03-10T03:19:45Z

In case it's helpful, Firebase CLI setup.
Scroll to the last category on the page - auth:import requires it.

FaisalAbid · 2017-03-10T05:07:18Z

Okay so the update on this, its failing actually because GitHub is saying too many requests from the travis ip. we are using the authenticated token. I am investigating the issue right now

LarkAscending · 2017-03-10T23:38:45Z

These PRs are failing again with the auth issue.
Totally looking forward to using this feature...

/cc @cbracken

sethladd · 2017-03-11T00:17:59Z

Can we turn this off in the meantime?

…

On Fri, Mar 10, 2017, 3:38 PM LarkAscending ***@***.***> wrote: These PRs are failing again with the auth issue. Totally looking forward to using this feature... /cc @cbracken <https://github.com/cbracken> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAVZywbYzEcUbFlb7MvTf0oA0mc8I1Vks5rkd8GgaJpZM4MT0JT> .

FaisalAbid · 2017-03-11T00:30:39Z

Hey, sorry guys, I've been at a family event all day. Let me send a PR to disable this and I'll take a look at the issue over the weekend

On Fri, Mar 10, 2017, 7:18 PM Seth Ladd ***@***.***> wrote: Can we turn this off in the meantime? On Fri, Mar 10, 2017, 3:38 PM LarkAscending ***@***.***> wrote: > These PRs are failing again with the auth issue. > Totally looking forward to using this feature... > > /cc @cbracken <https://github.com/cbracken> > > — > You are receiving this because you modified the open/close state. > > > Reply to this email directly, view it on GitHub > <#416 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AAAVZywbYzEcUbFlb7MvTf0oA0mc8I1Vks5rkd8GgaJpZM4MT0JT > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPfBE8ByF23qSFk2SK2gHtk-0-IV692ks5rkeg4gaJpZM4MT0JT> .

--

…

Sent from my phone

googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Mar 6, 2017

FaisalAbid force-pushed the flutter_stager branch 2 times, most recently from c4c6d72 to 24ef4ac Compare March 6, 2017 19:14

sethladd reviewed Mar 6, 2017

View reviewed changes

FaisalAbid force-pushed the flutter_stager branch from b8620fe to 2b7e16f Compare March 7, 2017 04:12

a14n reviewed Mar 7, 2017

View reviewed changes

sethladd reviewed Mar 8, 2017

View reviewed changes

FaisalAbid force-pushed the flutter_stager branch from d6b86b0 to 12e377a Compare March 8, 2017 06:04

FaisalAbid force-pushed the flutter_stager branch from 12e377a to 7d27768 Compare March 9, 2017 03:48

Flutter Stage Deployer

5bee8eb

FaisalAbid force-pushed the flutter_stager branch from 7d27768 to 5bee8eb Compare March 9, 2017 15:37

sethladd merged commit 7703bfb into master Mar 9, 2017

sethladd deleted the flutter_stager branch March 9, 2017 23:15

		@@ -0,0 +1,90 @@
		// Copyright (c) 2017, FaisalAbid. All rights reserved. Use of this source code


		FirebaseClient fbClient = new FirebaseClient(firebaseAuth);

		List prsList = await getPullRequests();

Flutter Stager #416

Flutter Stager #416

Conversation

FaisalAbid commented Mar 6, 2017

FaisalAbid commented Mar 6, 2017

FaisalAbid commented Mar 6, 2017 • edited

sethladd commented Mar 6, 2017

FaisalAbid commented Mar 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hixie Mar 6, 2017 • edited

Choose a reason for hiding this comment

sethladd commented Mar 6, 2017

FaisalAbid commented Mar 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sethladd commented Mar 8, 2017

FaisalAbid commented Mar 8, 2017

sethladd commented Mar 8, 2017

FaisalAbid commented Mar 8, 2017

FlutterBot commented Mar 8, 2017

sethladd commented Mar 8, 2017

FaisalAbid commented Mar 8, 2017

FlutterBot commented Mar 9, 2017

FaisalAbid commented Mar 9, 2017

sethladd commented Mar 9, 2017

LarkAscending commented Mar 10, 2017 • edited

FaisalAbid commented Mar 10, 2017

LarkAscending commented Mar 10, 2017

FaisalAbid commented Mar 10, 2017

LarkAscending commented Mar 10, 2017

sethladd commented Mar 11, 2017 via email

FaisalAbid commented Mar 11, 2017 via email

FaisalAbid commented Mar 6, 2017 •

edited

Hixie Mar 6, 2017 •

edited

LarkAscending commented Mar 10, 2017 •

edited