-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first version of flutter.io/docs #817
Conversation
This will be the “index” of our docs (as the homepage will lack sidenav pretty soon).
This seems great! ...But, can I see it staged? |
One downside is that it will now require 2 clicks instead of 1 to get to API docs from any page on flutter.io, since it's no long part of the top navigation. We should track how this change affects API doc usage. |
| ||
|
||
|
||
## Want to skill up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be easy to understand for non-native speakers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
@Sfshaza, what are our options to rephrase?
* [Flutter Widget Inspector](/inspector/) | ||
The Flutter Inspector, a tool available in the Flutter plugin for your IDE. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is because there is not enough space between ul
and headers.
The implementation is ugly but the special-case CSS would be even uglier. When I have time, I'll see if changing the CSS everywhere to give more margin between ul
and h2
won't break some page somewhere.
Alright, I fixed the example link, and confirmed we're not breaking any other links. I think I'll merge. |
The URLs worked, but: * /setup is redirected to /get-started/install/, so let’s use the final destination itself * let’s use URLs with trailing slash, as that seems to be the canonical way on flutter.io
This will be the “index” of our docs (as the homepage will lack sidenav pretty soon).