Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Play Flag In DefaultAssetPickerViewerBuilderDelegate #585

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

yujune
Copy link
Contributor

@yujune yujune commented May 21, 2024

Add autoPlay flag in DefaultAssetPickerViewerBuilderDelegate to auto play video, audio and live photo.

Result

Simulator Screen Recording - iPhone 15 Pro Max - 2024-05-21 at 18 55 03

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally you need to add docs for the new field. Also it is worth it to add it to the AssetPickerConfig. I'd prefer the name as shouldPreviewAutoPlay additionally.

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply

README.md Show resolved Hide resolved
lib/src/constants/config.dart Outdated Show resolved Hide resolved
README-ZH.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
yujune and others added 2 commits July 30, 2024 10:53
Co-authored-by: Alex Li <github@alexv525.com>
Co-authored-by: Alex Li <github@alexv525.com>
@AlexV525 AlexV525 merged commit ecb2cdd into fluttercandies:main Jul 30, 2024
5 checks passed
@yujune yujune deleted the add-autoplay-flag branch July 30, 2024 03:31
tourdt pushed a commit to tourdt/flutter_wechat_assets_picker that referenced this pull request Jul 31, 2024
* main:
  Add Auto Play Flag In DefaultAssetPickerViewerBuilderDelegate (fluttercandies#585)
  ✨ Introduce `AssetsChangeRefreshPredicate` (fluttercandies#600)
  ⚡ Improve assets viewing (fluttercandies#605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants