Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VideoPlayerController initialization to adhere to video_player ^2.8.2 guidelines #814

Merged
merged 1 commit into from Apr 1, 2024
Merged

Refactor VideoPlayerController initialization to adhere to video_player ^2.8.2 guidelines #814

merged 1 commit into from Apr 1, 2024

Conversation

ishworpanta10
Copy link
Contributor

Updated VideoPlayerController initialization to use VideoPlayerController.networkUrl(Uri.parse('video_url')), complying with video_player ^2.8.2 guidelines.

Changes :

final videoPlayerController = VideoPlayerController.network(
    'https://flutter.github.io/assets-for-api-docs/assets/videos/butterfly.mp4'); 
   
   To 
   
   final videoPlayerController = VideoPlayerController.networkUrl(Uri.parse(
    'https://flutter.github.io/assets-for-api-docs/assets/videos/butterfly.mp4'));

@ishworpanta10
Refactor VideoPlayerController initialization to adhere to video_play…
7bf1a54 
…er ^2.8.2 guidelines

Updated VideoPlayerController initialization to use VideoPlayerController.networkUrl(Uri.parse('video_url')), complying with video_player ^2.8.2 guidelines.
@ycv005
Copy link
Contributor

ycv005 commented Mar 30, 2024

please update chewie to support wakelock_plus: ^1.2.1.

diegotori
diegotori approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori diegotori merged commit 53e964b into fluttercommunity:master Apr 1, 2024
diegotori added a commit that referenced this pull request Apr 1, 2024
@diegotori
chewie, version 1.8.0. Addresses #814, #815, #821, and #824.
93dc6d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegotori diegotori diegotori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ishworpanta10 @ycv005 @diegotori