Fix the Safe area conflict for material controls in Android #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue:
When a player widget is used inside a scaffold with
extendBodyBehindAppBarset to true on a Scaffold, the progress bar and the fullscreen button go out of the player bounds which breaks the layout and makes them inaccessible for a user's input.Example from real app:
extendBodyBehindAppBar: true, controls are falling downextendBodyBehindAppBar: false, controls are fine, but we need the content of the screen go under the app barextendBodyBehindAppBar: true, and the fix from PRThis is how it should work.
If I got it right the issue is Android/Fucsia related, since MaterialControls do not used for others. This was not tested on Fucsia.