Merge pull request #274 from happy-san/patch-1

Fix: Success message printed on exception
fluttercommunity · Aug 22, 2021 · 314d0a9 · 314d0a9
2 parents 590a83f + d0f6dab
commit 314d0a9
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/main.dart b/lib/main.dart
@@ -58,11 +58,11 @@ Future<void> createIconsFromArguments(List<String> arguments) async {
   if (!hasFlavors) {
     try {
       createIconsFromConfig(yamlConfig);
+      print('\n✓ Successfully generated launcher icons');
     } catch (e) {
+      stderr.writeln('\n✕ Could not generate launcher icons');
       stderr.writeln(e);
       exit(2);
-    } finally {
-      print('\n✓ Successfully generated launcher icons');
     }
   } else {
     try {
@@ -72,11 +72,11 @@ Future<void> createIconsFromArguments(List<String> arguments) async {
             loadConfigFile(flavorConfigFile(flavor), flavorConfigFile(flavor));
         await createIconsFromConfig(yamlConfig, flavor);
       }
+      print('\n✓ Successfully generated launcher icons for flavors');
     } catch (e) {
+      stderr.writeln('\n✕ Could not generate launcher icons for flavors');
       stderr.writeln(e);
       exit(2);
-    } finally {
-      print('\n✓ Successfully generated launcher icons for flavors');
     }
   }
 }