Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we use dev_dependencies? #3

Closed
sethladd opened this issue Dec 5, 2017 · 4 comments
Closed

should we use dev_dependencies? #3

sethladd opened this issue Dec 5, 2017 · 4 comments

Comments

@sethladd
Copy link

sethladd commented Dec 5, 2017

In the README, you say to put the package under "dependencies", but that's intended to list packages required to run the app.

I think we can use dev_dependencies for this util script?
@franzsilva
Copy link
Collaborator

Yes, that sounds right. We can use dev_dependencies. Will work on that

@MarkOSullivan94
Copy link
Collaborator

Just tested this out and it works fine listed under dev_dependencies. Updated the README to include this change among others.

@MarkOSullivan94
Copy link
Collaborator

@sethladd README changes have been merged in so dev_dependencies is used instead. Think this can be closed now?

@sethladd
Copy link
Author

thanks!

@gizmomogwai gizmomogwai mentioned this issue Mar 4, 2018
Closed
@xiechunyan xiechunyan mentioned this issue Apr 3, 2018
Closed
@sanjul sanjul mentioned this issue Aug 26, 2018
Closed
@thewithz thewithz mentioned this issue Sep 13, 2020
Closed
@monizj monizj mentioned this issue Oct 19, 2020
Closed
@SamerOrfali SamerOrfali mentioned this issue Dec 8, 2020
Closed
@happy-san happy-san mentioned this issue Jan 9, 2021
Closed
@yakkobr yakkobr mentioned this issue Nov 7, 2021
Open
@leech001 leech001 mentioned this issue Nov 20, 2021
Closed
marcobazzani added a commit to marcobazzani/flutter_launcher_icons that referenced this issue Dec 18, 2021
@marcobazzani
Fix FormatException on latest flutter configuration files
49ce13c 
Fixing this error on new flutter configs 
```
  ════════════════════════════════════════════
     FLUTTER LAUNCHER ICONS (v0.9.1)
  ════════════════════════════════════════════


✓ Successfully generated launcher icons
Unhandled exception:
FormatException: Invalid number (at character 1)

^

#0      int._handleFormatError (dart:core-patch/integers_patch.dart:129:7)
fluttercommunity#1      int.parse (dart:core-patch/integers_patch.dart:55:14)
fluttercommunity#2      minSdk (package:flutter_launcher_icons/android.dart:309:18)
fluttercommunity#3      createIconsFromConfig (package:flutter_launcher_icons/main.dart:94:47)
fluttercommunity#4      createIconsFromArguments (package:flutter_launcher_icons/main.dart:60:7)
fluttercommunity#5      main (file:///Users/marcobazzani/Projects/flutter_launcher_icons/bin/main.dart:6:26)
fluttercommunity#6      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295:32)
fluttercommunity#7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192:12)
```
@bahiraei bahiraei mentioned this issue Dec 23, 2021
Closed
@lcyper lcyper mentioned this issue Dec 24, 2021
Closed
@harr1424 harr1424 mentioned this issue Dec 31, 2021
Closed
@cacothi cacothi mentioned this issue Jan 27, 2022
Closed
@amalikmuhd amalikmuhd mentioned this issue Feb 5, 2022
Closed
@beingbivek beingbivek mentioned this issue Mar 2, 2022
Closed
@KurtLa KurtLa mentioned this issue Mar 3, 2022
Closed
@ghost ghost mentioned this issue Mar 22, 2022
Closed
@OnClickListener2048 OnClickListener2048 mentioned this issue Apr 6, 2022
Closed
@santo-apps santo-apps mentioned this issue Apr 22, 2022
Closed
@dam322 dam322 mentioned this issue Jun 9, 2022
Closed
@StenlyAndika StenlyAndika mentioned this issue Jun 11, 2022
Closed
@Abdulkader-Safi Abdulkader-Safi mentioned this issue Jul 24, 2022
Closed
@jeevankoiri10 jeevankoiri10 mentioned this issue Jul 30, 2022
Closed
@sara010 sara010 mentioned this issue Apr 23, 2023
Open
@jbridgenet jbridgenet mentioned this issue Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sethladd @franzsilva @MarkOSullivan94