-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ UIBackgroundFetchResult ordinal mapping #20
Comments
Actually this was an idea we already discussed with @jeremie-movify and @petermnt before. Ideally we would want to return some sort of Android already expects either a:
As of now (
I thought the iOS return code was similarly mapped. We could then have something like:
|
This issue is actually about something else. |
Ok I misunderstood I'll open another ticket for the idea from above 👍 |
* Introduced simple wrapper around os_log for readability Ideally this should live in a separate little utility framework which this plugin could depend on, but good enough for now. * Cast flutterResult as bool and return correct UIBackgroundFetchResult - Now we don't rely on the internal ordering of `UIBackgroundFetchResult`'s cases: fixes #20 - Because `flutterResult` is a bool (for now, see #23), it now calls the completionhandler with a *correct* `UIBackgroundFetchResult`: Fixes #21 * Added some more info logging * Cleanup `flutterEngine` after work has been done Fixes #19
Currently in the
setMethodCallHandler
block ofbackgroundMethodChannel
aUIBackgroundFetchResult
is created using the flutter resultInt
like so:UIBackgroundFetchResult(rawValue: UInt(fetchResult))
We shouldn't rely on the internal ordering of
UIBackgroundFetchResult
case
s, as they could change with future iOS releases.The text was updated successfully, but these errors were encountered: