Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[battery_plus] null-safety #114

Merged
merged 15 commits into from
Feb 22, 2021
Merged

[battery_plus] null-safety #114

merged 15 commits into from
Feb 22, 2021

Conversation

miquelbeltran
Copy link
Member

See #50

@miquelbeltran miquelbeltran marked this pull request as draft February 4, 2021 09:37
@miquelbeltran
Copy link
Member Author

miquelbeltran commented Feb 19, 2021

blocked by this:

The current Dart SDK version is 2.12.0-259.12.beta.

Because no versions of dbus match >0.2.0 <0.3.0 and dbus 0.2.0 depends on xml ^5.0.0, dbus ^0.2.0 requires xml ^5.0.0.
Because xml 5.0.0 requires SDK version >=2.12.0-259.14.beta <3.0.0 and no versions of xml match >5.0.0 <6.0.0, xml ^5.0.0 is forbidden.
Thus, dbus ^0.2.0 is forbidden.
So, because battery_plus_linux depends on dbus ^0.2.0, version solving failed.
pub get failed (1; So, because battery_plus_linux depends on dbus ^0.2.0, version solving failed.

@jpnurmi
Copy link
Member

jpnurmi commented Feb 19, 2021

Is it because xml sdk contraint is '>=2.12.0-259.14.beta <3.0.0'?

https://github.com/renggli/dart-xml/blob/main/pubspec.yaml#L8

@jpnurmi
Copy link
Member

jpnurmi commented Feb 19, 2021

@jpnurmi
Copy link
Member

jpnurmi commented Feb 19, 2021

Aaaand next:

Running "flutter pub get" in example...                         
Because every version of battery_plus from path depends on battery_plus_linux from path which depends on dbus ^0.2.0, every version of battery_plus from path requires dbus ^0.2.0.
And because dbus >=0.2.0 depends on args ^2.0.0 and every version of flutter_driver from sdk depends on args 1.6.0, battery_plus from path is incompatible with flutter_driver from sdk.
So, because battery_plus_example depends on both flutter_driver any from sdk and battery_plus from path, version solving failed.
pub get failed (1; So, because battery_plus_example depends on both flutter_driver any from sdk and battery_plus from path, version solving failed.)

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get past the args conflict, you can add to battery_plus/example/pubspec.yaml:

dependency_overrides:
  args: ^2.0.0

#50 (comment)

packages/battery_plus_linux/pubspec.yaml Outdated Show resolved Hide resolved
packages/battery_plus/pubspec.yaml Outdated Show resolved Hide resolved
@miquelbeltran miquelbeltran changed the title [wip] [battery_plus] null-safety [battery_plus] null-safety Feb 22, 2021
@miquelbeltran miquelbeltran marked this pull request as ready for review February 22, 2021 07:53
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miquelbeltran miquelbeltran merged commit f3d119a into main Feb 22, 2021
@miquelbeltran miquelbeltran deleted the mb-battery_plus-nullsafety branch February 22, 2021 11:44
@miquelbeltran
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants