Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectivity_plus] address pub score (#16) #141

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Feb 16, 2021

Importing platform_interface/src/foo.dart in the main package loses 10 pub score points:

Pass static analysis

20/30 points: code has no errors, warnings, lints, or formatting issues

INFO: Don't import implementation files from another package.

…y#16)

Importing platform_interface/src/foo.dart loses 10 pub score points:

    Pass static analysis

    20/30 points: code has no errors, warnings, lints, or formatting issues

    INFO: Don't import implementation files from another package.
Copy link
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpnurmi jpnurmi merged commit 6766e3b into fluttercommunity:main Feb 16, 2021
@jpnurmi jpnurmi deleted the fix/connectivity_plus_score branch February 16, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants