Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(battery_plus)!: Introduce connected_not_charging state on MacOS #2399

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

vbuberen
Copy link
Collaborator

@vbuberen vbuberen commented Nov 30, 2023

Description

Adding new connected_not_charging state to MacOS as follow-up to #2275 which introduced such state on Android.
Renamed the state from the initial name suggested in #2275 to be more explicit.

Marking as a breaking change to bring attention to the new state in platform interface and because I have reimplemented MacOS states definition.

Looks like this state can be added for Linux as well, so will open one more PR for Linux platform.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen changed the title feature(battery_plus)!: Introduce connected_not_charging state on MacOS feat(battery_plus)!: Introduce connected_not_charging state on MacOS Nov 30, 2023
@vbuberen vbuberen merged commit 78f44bf into main Dec 1, 2023
20 of 21 checks passed
@vbuberen vbuberen deleted the update/battery_plus_macos_state branch December 1, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant