Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: RxCommandAsync blocks after an Error in handler #26

Closed
Eupatech opened this issue Aug 22, 2019 · 5 comments
Closed

Bug: RxCommandAsync blocks after an Error in handler #26

Eupatech opened this issue Aug 22, 2019 · 5 comments

Comments

@Eupatech
Copy link

_isRunning muss be set to false in handleError() call in rx_command.dart file at line 467.

@Eupatech
Copy link
Author

class RxCommandAsync<TParam, TResult> extends RxCommand<TParam, TResult> {
...
@OverRide
execute([TParam param]) {
...
_func(param).asStream().handleError((error) {
if (throwExceptions) {
_resultsSubject.addError(error);
_isRunning = false; // <------------------------------ Bug. add _isrunning=false
return;
}
...

@escamoteur
Copy link
Collaborator

I'm just on it. This only happens if you set throwException=true' Why do you need throwException=true' ?

@escamoteur
Copy link
Collaborator

Should be fixed in 4.3.2

@Eupatech
Copy link
Author

Eupatech commented Aug 23, 2019 via email

@escamoteur
Copy link
Collaborator

I would then recommend to use the . results Observable for your Stream Builder the you get all state information at once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants