Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dispose in Hook uncancellable #234

Closed
Avaq opened this issue Mar 11, 2018 · 0 comments
Closed

Make dispose in Hook uncancellable #234

Avaq opened this issue Mar 11, 2018 · 0 comments

Comments

@Avaq
Copy link
Member

Avaq commented Mar 11, 2018

Based on this Gitter conversation and the PureScript Aff documentation of bracket it seems to me that Future.hook would be more correct if it would never cancel the dispose Future.

Avaq added a commit that referenced this issue Apr 6, 2018
Avaq added a commit that referenced this issue Apr 6, 2018
Avaq added a commit that referenced this issue Apr 6, 2018
@Avaq Avaq closed this as completed in #238 May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant