Improve correctness of Future.hook #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 1187 1196 +9
=====================================
+ Hits 1187 1196 +9
Continue to review full report at Codecov.
|
Avaq
force-pushed
the
avaq/hook-correctness
branch
from
56bb20f
to
f807a3f
Compare
| In the case where the consumption Future settles, the disposal is forked and | ||
| awaited. If the disposal Future rejects or encounters an exception, it will | ||
| replace the state of the consumption Future. Otherwise the rejection reason or | ||
| resolution value of the consumption Future will determine the final outcome. |
There was a problem hiding this comment.
Is “consumption” being used as an adjective here? This doesn't sound right to me.
There was a problem hiding this comment.
I need to quick way to refer to "the Future returned by the consume function".
safareli
reviewed
Apr 13, 2018
Alright, no worries! |
Avaq
added a commit
that referenced
this pull request
Jul 26, 2018
Breaking changes - #224 Exceptions are now caught and rethrown in `fork`. - #230 Many of the TypeScript type definitions that used `never` now use a generic instead. - #238 When unsubscribing from a Future created by `hook`, the cancellation signal is no longer sent to the disposal Future. - #266 Exported TypeScript interfaces have been renamed to avoid naming conflicts with exported values. New features - #250 Included interoperability with Sanctuary Show - #261 Added a new function, `forkCatch`, which allows for exception recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two significant changes to how Hook works:
I've tried to explain these semantics in the README.
@safareli I've asked you for a review because this change affects semantics and is partly inspired by PureScript Aff.
Ping @syaiful6 because you were the person to bring this to my attention.